-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improved Python binary detection #1648
Merged
kzantow
merged 7 commits into
anchore:main
from
kzantow-anchore:fix/improved-python-binary-detection
Mar 7, 2023
Merged
fix: improved Python binary detection #1648
kzantow
merged 7 commits into
anchore:main
from
kzantow-anchore:fix/improved-python-binary-detection
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
…chers Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Mar 7, 2023
wagoodman
reviewed
Mar 7, 2023
wagoodman
reviewed
Mar 7, 2023
wagoodman
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only blocking comment is the note about mode
as an indicator for parsing, other than that 💯 !
Signed-off-by: Keith Zantow <kzantow@gmail.com>
This was referenced Mar 9, 2023
Closed
we lost some information on python binaries after this PR: syft v0.74.0
syft v0.74.1
|
@noqcks could you give the json output for those packages between the versions? |
This was referenced Mar 14, 2023
spiffcs
added a commit
to deitch/syft
that referenced
this pull request
Mar 21, 2023
* main: (47 commits) Deprecate config.yaml as valid config source; Add unit regression for correct config paths (anchore#1640) chore: Update syft bootstrap tools to latest versions. (anchore#1682) Update documentation: (anchore#1680) chore: Update Stereoscope to 7928713c391e20abaede6a029f4ce37b628a4c8b (anchore#1681) fix: reduce logging for bad dpkg lines (anchore#1675) fix ruby classifier (anchore#1678) feat: add shared dir for easier cleanup (anchore#1676) chore(deps): bump github.com/google/go-containerregistry (anchore#1672) chore(deps): bump actions/setup-go from 3 to 4 (anchore#1671) fix: move defer after error to protect panic case (anchore#1670) feat: add argocd, helm, kustomize and kubectl binary classifiers (anchore#1663) defer closing file (anchore#1668) fix: remove author contributing to javascript CPEs (anchore#1669) fix: more python matching support (anchore#1667) Update syft bootstrap tools to latest versions. (anchore#1666) feat: add ruby classifier (anchore#1665) Update syft bootstrap tools to latest versions. (anchore#1658) fix: improved Python binary detection (anchore#1648) fix: suppress some known incorrect vendor candidates for npm CPEs (anchore#1659) fix: sanitize SPDX LicenseRefs (anchore#1657) ... Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, when Python binary detection was added, it checked 3 sources:
python*
binaries directlylibpython*
shared librariespatchlevel.h
source fileThe reason for the latter 2 - especially the last one, is that some Python binaries do not actually contain version information but instead load a
libpython*
shared library, which contains this.This has caused some confusion for users and did not necessarily prove to be the most accurate. This PR changes the behavior such that
patchlevel.h
is never looked for, as there is no guarantee this would be applicable to the particular python binary file found. Additionally, when inspecting Python binaries, the behavior is now:libpython*
shared library in the binary dynamic library list, and extract version information from that fileWith this change, Syft does still look for
libpython*
files independently, and these may or may not show up as the primary location for a package.The result is a few different cases:
A Python binary is found, with version information and a libpython shared library is found. If the versions are the same, both locations will be merged to the same package. If the versions are different, there will be 2 distinct packages with the corresponding location information.
A Python binary is found, without version information and a libpython shared library is found. If the libpython library is referenced from the Python binary, the primary location is the Python binary, and secondary location information includes the libpython library.
No Python binary is found but a libpython shared library is found. This will continue to surface Python findings, with the primary location of the libpython library.
The reason for the last described case is that there are situations a container may have libpython without a binary -- for example an Apache HTTP Server image with a Python module. In this case, it is important to surface the fact that there may be Python execution with library and version found.
Fixes: #1643
Also fixes: #1646