Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Add a Docker Setup #397

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Add a Docker Setup #397

merged 1 commit into from
Mar 20, 2022

Conversation

mhellmeier
Copy link

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (Give an overview)

Add a docker setup for local testing and development to fix #396.

Is there anything you'd like reviewers to focus on?

No.

@andi34
Copy link
Owner

andi34 commented Mar 17, 2022

There was a docker file added for review in the past, but I am not familiar with docker to be true.
andreknieriem#180

@mhellmeier
Copy link
Author

I also checked that Dockerfile. It builds everything from scratch by using the debian:buster-slim image. In my opinion, that's too complicated because other developers created scripts for that. Therefore, I used the webdevops/php-nginx image that comes with a pre-build nginx server and PHP installed to reduce the maintenance overhead.

If you aren't familiar with docker you can have a look at the commands used in the Dockerfile. I got them from the current installation script and the wiki.

I tested the whole setup and it works pretty well! I would be very happy to see it merged in the current dev branch.

If you want to test it on your machine:

  1. Install docker
  2. Install docker-compose
  3. Open a terminal in the project directory and execute docker-compose up --build
  4. That's it! Visit localhost:8080 in a browser and it should show the Photobooth application!

@andi34 andi34 merged commit 190fb6d into andi34:dev Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Docker + Docker-Compose Setup
2 participants