Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for easy local testing #180

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

rawbertp
Copy link
Contributor

@rawbertp rawbertp commented Nov 4, 2019

I created a Dockerfile which allows for easy local testing. This is for development purposes only and might be useful for other contributors too.

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@andi34
Copy link
Collaborator

andi34 commented Nov 4, 2019

"apt install" should be enough instead "apt-get install"

Dockerfile Show resolved Hide resolved
@rawbertp rawbertp force-pushed the rp-dockerfile branch 2 times, most recently from ffed4e5 to 9cea08d Compare November 4, 2019 19:59
@rawbertp
Copy link
Contributor Author

rawbertp commented Nov 4, 2019

"apt install" should be enough instead "apt-get install"

See here why apt-get should be used in scripts rather than apt: https://askubuntu.com/a/990838

@andi34
Copy link
Collaborator

andi34 commented Nov 4, 2019

"apt install" should be enough instead "apt-get install"

See here why apt-get should be used in scripts rather than apt: https://askubuntu.com/a/990838

Then Line 30 (&& apt update && apt install -y yarn) needs an update

@rawbertp rawbertp force-pushed the rp-dockerfile branch 2 times, most recently from fe3c89c to c20fd06 Compare November 4, 2019 20:08
@sualko
Copy link
Collaborator

sualko commented Nov 5, 2019

Looks good, but I have to give it a try if I have more time.

@rawbertp rawbertp force-pushed the rp-dockerfile branch 2 times, most recently from 5746fce to 79620e5 Compare November 6, 2019 12:49
Dockerfile Outdated Show resolved Hide resolved
@andi34 andi34 force-pushed the master branch 2 times, most recently from 847f587 to cf39905 Compare January 11, 2020 16:07
@andreknieriem andreknieriem merged commit e501d9b into andreknieriem:master Jul 5, 2021
@andi34 andi34 mentioned this pull request Mar 17, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants