Fixes flakiness in app's screenshot tests #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardsurfer
approved these changes
Apr 23, 2024
Combined test coverage report
Files
|
Jaehwa-Noh
reviewed
Apr 24, 2024
app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/TestSyncModule.kt
Outdated
Show resolved
Hide resolved
JoseAlcerreca
changed the title
This was referenced Apr 24, 2024
Combined test coverage report
Files
|
JoseAlcerreca
force-pushed
the
ja/disable_wm_init
branch
from
af96293
to
ee362f6
Compare
Combined test coverage report
Files
|
keyboardsurfer
approved these changes
Apr 24, 2024
JoseAlcerreca
force-pushed
the
ja/disable_wm_init
branch
from
0b88dd0
to
929b52a
Compare
Change-Id: Ib0994e744f49b53f58c0eebd52f80c0eba67bbed
Change-Id: I5a25a7e156d3fcb72a396d3b503e62068a20b417
Change-Id: Iac36347dc3d702248d7515a74823e0bc0cbf2a2b
Change-Id: Ic517e8822218abeaddd3f8d2740b03e651d72d31
Change-Id: Ia42fb78781d2469a608183594fc25c7c69f7e76c
JoseAlcerreca
force-pushed
the
ja/disable_wm_init
branch
from
929b52a
to
26b53b9
Compare
keyboardsurfer
approved these changes
Apr 24, 2024
Combined test coverage report
Files
|
big-guy
added a commit
to gradle/nowinandroid
that referenced
this pull request
Apr 25, 2024
* origin/main: Fixes flakiness in app's screenshot tests (android#1395) Revert "Configure baseline profiles in the baselineProfile lambda" (android#1398) Configure baseline profiles in the baselineProfile lambda (android#1060) Enable strong skipping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were disabling WorkManager inside the SyncManager instead of disabling SyncManager altogether. This was throwing some SQLite errors (that are printed out but don't fail the test)
This is the first change to address #1394.
We might want to move that TestSyncModule to another module in the future.
This also enables LocalInspectionMode to prevent the flakiness and pins the timezone.