fix same-object copies in deepcopy
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously same-object references were not copied correctly and the following would fail. ``` x = Indices() y = deepcopy((x, x)) @test y[1] === y[2] ``` In order to not copy the same object multiple times in `deepcopy`, an `IdDict` is passed to `deepcopy_internal` which should be used by implementations. This commit makes use of that dictionary to store already copied objects and fix the above issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 80.10% 80.12% +0.02%
==========================================
Files 20 20
Lines 2357 2360 +3
==========================================
+ Hits 1888 1891 +3
Misses 469 469 ☔ View full report in Codecov by Sentry. |
andyferris
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously same-object references were not copied correctly and the following would fail.
In order to not copy the same object multiple times in
deepcopy, anIdDictis passed todeepcopy_internalwhich should be used by implementations.This commit makes use of that dictionary to store already copied objects and fix the above issue.
Also
deepcopy_internalonDictionarywas superfluous and was removed along the way.