Fix deepcopy when used after delete!
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 80.24% 80.23% -0.01%
==========================================
Files 21 21
Lines 2359 2363 +4
==========================================
+ Hits 1893 1896 +3
- Misses 466 467 +1 ☔ View full report in Codecov by Sentry. |
andyferris
approved these changes
Jan 30, 2024
|
Thank you for maintaining this package and quickly fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
The bug fixed in #112 was reintroduced in #131 when one of the
deepcopy_internalmethods was deleted.I have added a basic test for this issue, but I think
deepcopyneeds more testing.CC: @stev47 @andyferris @theogf