includedByState filter not fully working

[cyrilf]

includedByState improvement proposition

tldr;

This works:

<div ng-show="'**.foo.**' | includedByState">Work</div>

and this don't.. (doesn't respect the second parameter, shown no matter what id is)

<div ng-show="'**.foo.**' | includedByState:{id: 'new'}">Do not work</div>

Long version

The downside with it is that it doesn't use all the params from the $state.includes function, it only cares about the first one, which is fullOrPartialStatename (as reported in the doc)

Here is a plunker to show it live. In this example you can see that the red message is shown, no matter the params passed to the filter.

---

The issue come from here in the code as it uses only a single param.

To resolve this, we can easily tweak the method to something like this: Gist, where params and options are given to the other method.

I may open a PR soon, but let me know what you think about it?

[eddiemonge]

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb

[cyrilf]

Hey @eddiemonge
I can understand that this isn't the most important issue. However, I think this is a quick win because I've already made the PR, and this isn't a breaking change. So I'll be very happy if you reconsider it.

(FYI, I've seen that the same issue will occurs in the 1.0 branch too, so I may push a PR soon if you want)

[eddiemonge]

Keeping the PR open in case @christopherthielen wants to pull it in to 1.0

[christopherthielen]

On mobile but this seems ok to me.

[christopherthielen]

Link the PR?

[cyrilf]

The PR for this is here
I didn't took the time to make one for the 1.0, but I may do it soon.

[cyrilf]

Ok, so here you are for the PR to the feature-1.0