feat($IncludedByStateFilter): add parameters to $IncludedByStateFilter #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR linked to #1736 but for version feature-1.0 Add parameters to the $IncludedByStateFilter: - params - options This allows to use more parameters on this filter and not only the fullOrPartialStatename parameter. Thanks to this improvement, the following now works (takes in account the id param): <div ng-show="'**.foo.**' | includedByState:{id: 'new'}">It works</div> Related doc: http://angular-ui.github.io/ui-router/site/#/api/ui.router.state.$state#methods_includes
|
Travis failed. Don't have time to check why at the moment. |
|
Yeah 1.0 tests are just failing currently |
|
Any news about this PR? 👋 |
nateabele
added a commit
that referenced
this pull request
Dec 8, 2015
feat($IncludedByStateFilter): add parameters to $IncludedByStateFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR linked to #1736 but for version feature-1.0
Add parameters to the $IncludedByStateFilter:
This allows to use more parameters on this filter and not only the fullOrPartialStatename parameter.
Thanks to this improvement, the following now works (takes in account the id param):
<div ng-show="'**.foo.**' | includedByState:{id: 'new'}">It works</div>Related doc: http://angular-ui.github.io/ui-router/site/#/api/ui.router.state.$state#methods_includes