-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request : ng build to include a --base-href <base> #1064
Comments
Implement --base-href argument for build and serve commands Closes angular#1064
I've started and actually did some work on this because I missed it in webpack version.. and I really need it. :| To make sure I'm in the right way I need someone of angular members approval about how this argument should work.
Also I'm thinking that instead of auto-prefixing url with slash whole url should be provided by developer for the case when I want to overwrite my |
I was gonna pick this one up, but if you're working on it I'm happy to help. I'm speaking as myself now, design for this feature hasn't been discussed within the team. There's a couple of extra things you have to look into when developing this feature:
As far as behavior goes, I think your proposal makes sense. I also agree the developer should provide the whole URL. |
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build and serve commands Closes angular#1064
Implement --base-href argument for build, serve and github-pages:deploy commands Closes angular#1064
Implement --base-href argument for build and github-pages:deploy commands Closes angular#1064
Implement --base-href argument for build and github-pages:deploy commands Closes angular#1064
Implement --base-href argument for build and github-pages:deploy commands Closes angular#1064
@dzonatan I'm not seeing it anywhere in the commit, but are you able to configure this option in the environment files instead? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Much like what happens as part of github deploy, have a feature that you can supply a base-href that will be added to the
index.html
during theng build
commandUsage :
ng build --base-href <base>
Example :
ng build --base-href home
Replaces
<base href="/">
with<base href="/home">
inindex.html
The text was updated successfully, but these errors were encountered: