forked from angular/angular-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: implement --base-href argument
Implement --base-href argument for build and serve commands Closes angular#1064
- Loading branch information
Showing
11 changed files
with
140 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| interface BaseHrefWebpackPluginOptions { | ||
| baseHref: string; | ||
| } | ||
|
|
||
| export class BaseHrefWebpackPlugin { | ||
| constructor(private options: BaseHrefWebpackPluginOptions) { } | ||
|
|
||
| apply(compiler): void { | ||
| // Ignore if baseHref is not passed | ||
| if (!this.options.baseHref) { | ||
| return; | ||
| } | ||
|
|
||
| compiler.plugin('compilation', (compilation) => { | ||
| compilation.plugin('html-webpack-plugin-before-html-processing', (htmlPluginData, callback) => { | ||
| // Check if base tag already exists | ||
| const baseTagRegex = /<base.*?>/i; | ||
| const baseTagMatches = htmlPluginData.html.match(baseTagRegex); | ||
| if (!baseTagMatches) { | ||
| // Insert it in top of the head if not exist | ||
| htmlPluginData.html = htmlPluginData.html.replace(/<head>/i, '$&' + `<base href="${this.options.baseHref}">`); | ||
| } else { | ||
| // Replace only href attribute if exists | ||
| const modifiedBaseTag = baseTagMatches[0].replace(/href="\S+"/i, `href="${this.options.baseHref}"`); | ||
| htmlPluginData.html = htmlPluginData.html.replace(baseTagRegex, modifiedBaseTag); | ||
| } | ||
|
|
||
| callback(null, htmlPluginData); | ||
| }); | ||
| }); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /*eslint-disable no-console */ | ||
| 'use strict'; | ||
|
|
||
| var expect = require('chai').expect; | ||
| var BaseHrefWebpackPlugin = require('../../addon/ng2/utilities/base-href-webpack-plugin').BaseHrefWebpackPlugin; | ||
|
|
||
| function mockCompiler(indexHtml, callback) { | ||
| return { | ||
| plugin: function (event, compilerCallback) { | ||
| var compilation = { | ||
| plugin: function (hook, compilationCallback) { | ||
| var htmlPluginData = { | ||
| html: indexHtml | ||
| }; | ||
| compilationCallback(htmlPluginData, callback); | ||
| } | ||
| }; | ||
| compilerCallback(compilation); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| describe.only('base href webpack plugin', function () { | ||
| it('should do nothing when baseHref is null', function () { | ||
| var plugin = new BaseHrefWebpackPlugin({ baseHref: null }); | ||
|
|
||
| var compiler = mockCompiler('<body><head></head></body>', function (x, htmlPluginData) { | ||
| expect(htmlPluginData.html).to.equal('<body><head></head></body>'); | ||
| }); | ||
| plugin.apply(compiler); | ||
| }); | ||
|
|
||
| it('should insert base tag when not exist', function () { | ||
| var plugin = new BaseHrefWebpackPlugin({ baseHref: '/' }); | ||
|
|
||
| var compiler = mockCompiler('<body><head></head></body>', function (x, htmlPluginData) { | ||
| expect(htmlPluginData.html).to.equal('<body><head><base href="/"></head></body>'); | ||
| }); | ||
| plugin.apply(compiler); | ||
| }); | ||
|
|
||
| it('should replace href attribute when base tag already exists', function () { | ||
| var plugin = new BaseHrefWebpackPlugin({ baseHref: '/myUrl/' }); | ||
|
|
||
| var compiler = mockCompiler('<body><head><base href="/" target="_blank"></head></body>', function (x, htmlPluginData) { | ||
| expect(htmlPluginData.html).to.equal('<body><head><base href="/myUrl/" target="_blank"></head></body>'); | ||
| }); | ||
| plugin.apply(compiler); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters