Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng github-pages:deploy still requires angular-cli-build.js #1672

Closed
JohannesHoppe opened this issue Aug 12, 2016 · 2 comments
Closed

ng github-pages:deploy still requires angular-cli-build.js #1672

JohannesHoppe opened this issue Aug 12, 2016 · 2 comments

Comments

@JohannesHoppe
Copy link
Contributor

  1. OS: Windows 8.1, but doesn't matter
  2. Versions.
angular-cli: 1.0.0-beta.11-webpack.2
node: 6.3.1
os: win32 x64
  1. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
    Fresh project created with ng new
  2. The log given by the failure. Normally this include a stack trace and some
    more information.
 ng github-pages:deploy
(node:10264) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
- BuildingNo angular-cli-build.js found. Please see the transition guide: https://github.com/angular-cli/angular-cli/blob/master/TRANSITION.md#user-content-brocfile-transition.
Error: No angular-cli-build.js found. Please see the transition guide: https://github.com/angular-cli/angular-cli/blob/master/TRANSITION.md#user-content-brocfile-transition.
    at Class.module.exports.Task.extend.setupBroccoliBuilder (D:\theFolder\node_modules\angular-cli\lib\models\builder.js:57:13)
    at Class.module.exports.Task.extend.init (D:\theFolder\node_modules\angular-cli\lib\models\builder.js:89:10)
    at new Class (D:\theFolder\node_modules\core-object\core-object.js:18:12)
    at Class.module.exports.Task.extend.run (D:\theFolder\node_modules\angular-cli\lib\tasks\build.js:15:19)
    at build (D:\theFolder\node_modules\angular-cli\addon\ng2\commands\github-pages-deploy.ts:108:30)
    at lib$rsvp$$internal$$tryCatch (D:\theFolder\node_modules\rsvp\dist\rsvp.js:1036:16)
    at lib$rsvp$$internal$$invokeCallback (D:\theFolder\node_modules\rsvp\dist\rsvp.js:1048:17)
    at lib$rsvp$$internal$$publish (D:\theFolder\node_modules\rsvp\dist\rsvp.js:1019:11)
    at lib$rsvp$asap$$flush (D:\theFolder\node_modules\rsvp\dist\rsvp.js:1198:9)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

`new BuildTask`` seems to depend on some outdated code...
see https://github.com/angular/angular-cli/blob/master/addon/ng2/commands/github-pages-deploy.ts#L71

Cheers!

@JohannesHoppe
Copy link
Contributor Author

@filipesilva on #1070:
Oh wow, good catch! We didn't update github-pages-deploy.ts to use the new tasks. I'll put up a PR doing that.
It only really depends on the build task so the logic shouldn't be affected at all.
I updated #1633 to also fix that, since I had to edit it in that PR as well.

This bug can be closed, since the PR #1633 is supposed to fix ng github-pages:deploy.

JohannesHoppe added a commit to angular-schule/angular-cli-ghpages that referenced this issue Aug 18, 2016
…ate angular-cli.json) has landed

see angular/angular-cli#1070 (Update README.md - mentioning angular-cli-ghpages addon)
see angular/angular-cli#1672 ( `ng github-pages:deploy` still requires `angular-cli-build.js` )
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant