-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md - mentioning angular-cli-ghpages addon #1070
Conversation
We created a similar addon on top of [tschaub/gh-pages](https://github.com/tschaub/gh-pages). It gives us much more flexibility where and how to push the builds to. In our case this plugin is the base for some smoke tests against a build matrix. Many thanks for considering! :-)
I can't merge this in, mostly because at the moment we're not really committed to the addon architecture. But what I'd be happy to merge in is you adding this functionality to the existing one directly. If you want to try your hand at that, I'll ask you to keep all existing functionality and add tests for new one. I did most of the code for the current one so feel free to ask me questions. |
@filipesilva Ok, so we got Webpack now. But |
Oh wow, good catch! We didn't update It only really depends on the build task so the logic shouldn't be affected at all. |
I updated #1633 to also fix that, since I had to edit it in that PR as well. |
I also reported this here: #1672 |
…ate angular-cli.json) has landed see angular/angular-cli#1070 (Update README.md - mentioning angular-cli-ghpages addon) see angular/angular-cli#1672 ( `ng github-pages:deploy` still requires `angular-cli-build.js` )
@JohannesHoppe now with |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Say hello to angular-cli-ghpages!
We created an addon on top of tschaub/gh-pages.
Compared to
github-pages:deploy
it gives us much more flexibility where and how to push the builds to.In our case this plugin is the base for some smoke tests against a build matrix.
Many thanks for considering! 😄