Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The twitter icon in the app template should be changed to the X logo #26012

Closed
ocombe opened this issue Oct 11, 2023 · 5 comments
Closed

The twitter icon in the app template should be changed to the X logo #26012

ocombe opened this issue Oct 11, 2023 · 5 comments

Comments

@ocombe
Copy link
Contributor

ocombe commented Oct 11, 2023

Command

new / generate

Is this a regression?

No

The previous version in which this bug was not present was

No response

Description

Twitter is now X (sic...), the Twitter icon in the topbar of the app template should be the X icon instead, and the alt tag should be X
image

Minimal Reproduction

Create a new angular workspace or generate a new application

Exception or Error

No response

Your Environment

Angular CLI: 17.0.0-next.7
Node: 20.4.0 (Unsupported)
Package Manager: npm 9.8.1
OS: win32 x64


Angular: 17.0.0-next.7
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0-next.7
@angular-devkit/build-angular   17.0.0-next.7
@angular-devkit/core            17.0.0-next.7
@angular-devkit/schematics      17.0.0-next.7
@schematics/angular             17.0.0-next.7
ng-packagr                      17.0.0-next.2
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.0

Anything else relevant?

No response

@SarthakD15
Copy link
Contributor

Hey, I would like to work on this. Can you please assign it to me ?

@JeanMeche
Copy link
Member

@SarthakD15 You can open submit a PR directly !

@SarthakD15
Copy link
Contributor

#26031

@SarthakD15
Copy link
Contributor

Hey, I have solved the issue and raised a PR :)
Please review the PR and suggest changes if any !

alan-agius4 pushed a commit to SarthakD15/angular-cli that referenced this issue Oct 17, 2023
alan-agius4 pushed a commit to SarthakD15/angular-cli that referenced this issue Oct 17, 2023
alan-agius4 pushed a commit to SarthakD15/angular-cli that referenced this issue Oct 17, 2023
alan-agius4 pushed a commit that referenced this issue Oct 18, 2023
Update twitter logo to x

Closes #26012

(cherry picked from commit 4b390ab)
alan-agius4 pushed a commit that referenced this issue Oct 18, 2023
Update twitter logo to x

Closes #26012

(cherry picked from commit 4b390ab)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants