-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter icon changed to X logo #26031
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tests/legacy-cli/e2e/assets/14.0-project/src/app/app.component.html
Outdated
Show resolved
Hide resolved
Sounds good to me! You will probably have to squash the commits and change the commit message to follow Angular guidelines, but I'll let the Google team check that 🙂 |
Thanks @ocombe |
Make sure that all the tests are green, looks like you're missing the CLA #26031 (comment) |
Yeah Thanks, Done! |
@SarthakD15 |
Hey, I am not getting what the commit message should be like it's little confusing for me. |
So looking at the code that you changed, I see that you only edited a test file, the code that generates the project files must be somewhere else, once you've edited those files you should see which package it belongs to. From there you can figure out how the commit message should be named. Something like: |
Hey, as I am a beginner actually I messed up a little. :( |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When we create a new application, the default application has the old twitter logo, which should get change to new logo.
Issue Number: N/A
What is the new behavior?
Now the logo has been changed to new X logo with correct dimensions.
Does this PR introduce a breaking change?
Other information