Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter icon changed to X logo #26031

Closed
wants to merge 2 commits into from
Closed

Conversation

SarthakD15
Copy link
Contributor

@SarthakD15 SarthakD15 commented Oct 13, 2023

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When we create a new application, the default application has the old twitter logo, which should get change to new logo.

Issue Number: N/A

What is the new behavior?

Now the logo has been changed to new X logo with correct dimensions.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Oct 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ocombe
Copy link
Contributor

ocombe commented Oct 13, 2023

Sounds good to me! You will probably have to squash the commits and change the commit message to follow Angular guidelines, but I'll let the Google team check that 🙂

@SarthakD15
Copy link
Contributor Author

Thanks @ocombe
So, what changes are expected from my side now or there are no changes ?

@ocombe
Copy link
Contributor

ocombe commented Oct 13, 2023

Make sure that all the tests are green, looks like you're missing the CLA #26031 (comment)

@SarthakD15
Copy link
Contributor Author

Yeah Thanks, Done!
All are green now !

@JeanMeche
Copy link
Member

JeanMeche commented Oct 13, 2023

@SarthakD15
You still need squash your commits and reword it following our guidelines.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Oct 13, 2023
@SarthakD15
Copy link
Contributor Author

Hey, I am not getting what the commit message should be like it's little confusing for me.
What type this is and what is the scope, can you please help me with this.
Is the type of this issue "build" ?

@ocombe
Copy link
Contributor

ocombe commented Oct 14, 2023

So looking at the code that you changed, I see that you only edited a test file, the code that generates the project files must be somewhere else, once you've edited those files you should see which package it belongs to. From there you can figure out how the commit message should be named. Something like: fix(@schematics/angular): change Twitter logo to X for example

@SarthakD15
Copy link
Contributor Author

SarthakD15 commented Oct 14, 2023

Hey, as I am a beginner actually I messed up a little. :(
#26039
This is the new PR

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants