Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng new creates application with deprecated RouterTestingModule #27691

Closed
1 task
tobiasge opened this issue May 23, 2024 · 2 comments · Fixed by #27851
Closed
1 task

ng new creates application with deprecated RouterTestingModule #27691

tobiasge opened this issue May 23, 2024 · 2 comments · Fixed by #27851

Comments

@tobiasge
Copy link

Command

new

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

When creating a new application I didn't expect the usage of a deprecated module in my app.component.spec.ts file.

Minimal Reproduction

ng new --inline-style false --inline-template false --package-manager bun --routing --skip-git --standalone false --strict true --ssr false --style scss my-test-app

Exception or Error

No response

Your Environment

$ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 18.0.0
Node: 20.12.1
Package Manager: bun 1.1.9
OS: linux x64

Angular: 18.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1800.0
@angular-devkit/build-angular   18.0.0
@angular-devkit/core            18.0.0
@angular-devkit/schematics      18.0.0
@schematics/angular             18.0.0
rxjs                            7.8.1
typescript                      5.4.5
zone.js                         0.14.6

Anything else relevant?

No response

theonly1me added a commit to theonly1me/angular-cli that referenced this issue Jun 14, 2024
…ng flag is present

update schematics to use RouterModule instead of RouterTestingModule when generating a new project with the --routing flag

Fixes angular#27691
@theonly1me
Copy link

Hi @alan-agius4, #27851 fixes this behavior, could you please take a look? Thanks!

theonly1me added a commit to theonly1me/angular-cli that referenced this issue Jun 17, 2024
…--routing flag is present

update schematics to use RouterModule instead of RouterTestingModule when generating a new project with the --routing flag

Fixes angular#27691
alan-agius4 pushed a commit that referenced this issue Jun 17, 2024
…--routing flag is present

update schematics to use RouterModule instead of RouterTestingModule when generating a new project with the --routing flag

Fixes #27691

(cherry picked from commit e3b8b78)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants