fix(@angular/cli): update schematics to use RouterModule when --routing flag is present #27851
Conversation
| import { AppComponent } from './app.component'; | ||
|
|
||
| describe('AppComponent', () => { | ||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({<% if (routing) { %> | ||
| imports: [ | ||
| RouterTestingModule | ||
| RouterModule.forRoot([]) |
There was a problem hiding this comment.
Wouldn't RouterModule be sufficient in this case?
There was a problem hiding this comment.
Maybe just RouterOutlet ?
There was a problem hiding this comment.
Wouldn't RouterModule be sufficient in this case?
Yes just using RouterModule should be sufficient since we are not registering any routes, but I found this comment when looking at related issues, which is why I updated it to use RouterModule.forRoot with an empty list of routes. Please let me know if you think it is unnecessary and can be removed.
There was a problem hiding this comment.
@atscott, what do you suggest here?
There was a problem hiding this comment.
RouterOutlet is the minimal thing to have in the imports here. If you aren’t trying to import anything more than is necessary, that’s the thing to do.
If you want developers to not have to learn about what parts they’re using and need to import, then RouterModule.forRoot([]) makes it work for cases where RouterLink is added to the component template (RouterModule alone would not).
There was a problem hiding this comment.
Thanks for your response @atscott. @alan-agius4, @eneajaho From an ease-of-use standpoint I feel it may be better to use RouterModule.forRoot([]), but I can make the change to use RouterOutlet, if you prefer that instead.
alan-agius4
added
target: patch
…--routing flag is present update schematics to use RouterModule instead of RouterTestingModule when generating a new project with the --routing flag Fixes angular#27691
theonly1me
force-pushed
the
fix/replace-router-testing-module
branch
from
aa7be7f to
27619a2
Compare
@alan-agius4 My bad, I've updated it now. |
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 18.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
update schematics to use RouterModule instead of RouterTestingModule when generating a new project with the --routing flag
Fixes #27691
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Running
ng new --inline-style false --inline-template false --package-manager bun --routing --skip-git --standalone false --strict true --ssr false --style scss my-test-appgenerates a new project with theRouterTestingModulewhich is deprecatedIssue Number: #27691
What is the new behavior?
Running
ng new --inline-style false --inline-template false --package-manager bun --routing --skip-git --standalone false --strict true --ssr false --style scss my-test-appgenerates a new projects with theRouterModuleDoes this PR introduce a breaking change?
Other information
NA