This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
I18n changes #12362
Merged
I18n changes #12362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add Closes #12307. Otherwise, LGTM |
Previously there was a custom built en-us locale that was included with angular.js. This made likely that it would get out of sync with the real en-us locale that is generated from the closure library. This change removes that custom one and uses the generated one instead. This also has the benefit of preventing the unwanted caught error on trying to load `ngLocale` during angular bootstrap. Closes angular#12134 Closes angular#8174
petebacondarwin
force-pushed
the
i18n-changes
branch
from
8fa8dde
to
2b68136
Compare
It seems that the case where the negative sign goes between the currency symbol and the numeric value is actually the special case and that locales that require this have it built in. So we should default to having the negative sign before the symbol. See http://cldr.unicode.org/translation/number-patterns and http://unicode.org/cldr/trac/ticket/5674 Closes angular#10158
This regeneration takes into account the changes due to: * update to closure library 27.0.1 * fix to default position of negative sign in currency formats Closes angular#12307 Closes angular#12362
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
This regeneration takes into account the changes due to: * update to closure library 27.0.1 * fix to default position of negative sign in currency formats Closes angular#12307 Closes angular#12362
ggershoni
pushed a commit
to ggershoni/angular.js
that referenced
this pull request
Sep 29, 2015
This regeneration takes into account the changes due to: * update to closure library 27.0.1 * fix to default position of negative sign in currency formats Closes angular#12307 Closes angular#12362
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10158
Closes #8174
Closes #12134