Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Inconsistent in en_US localization #12134

Closed
tdrozdz opened this issue Jun 16, 2015 · 3 comments
Closed

Inconsistent in en_US localization #12134

tdrozdz opened this issue Jun 16, 2015 · 3 comments
Assignees
@petebacondarwin
Labels
component: $location
Milestone
1.4.4

Comments

@tdrozdz
Copy link

tdrozdz commented Jun 16, 2015

Hi, during development on localizations I've noticed that in core angular code localization for en_US looks different than in a file with localizations exposed as bower dep.

value in angular core

angular.js/src/ng/locale.js

Line 36 in 291d7c4

posPre: '\u00A4',

value in bower dep
https://github.com/angular/bower-angular-i18n/blob/master/angular-locale_en-us.js#L118

I'm not sure which one is correct so don't want to create PR but would be great if we could have the same value in both cases.
@lgalfaso lgalfaso added this to the 1.4.2 milestone Jun 16, 2015
@lgalfaso
Copy link
Contributor

This looks like a valid bug. Thanks for reporting this.

If someone wants to put together a PR, it would be ideal. If not I will look into this before the next release

@petebacondarwin petebacondarwin modified the milestones: 1.4.2, 1.4.3 Jul 6, 2015
@matsko matsko modified the milestones: 1.4.3, 1.4.4 Jul 14, 2015
@petebacondarwin
Copy link
Member

It seems weird that we have a "sort-of" duplicate of the en-us locale inside the ng module.
If we just copied the ngLocale module for en-us into the angular.js file, we would lose 400 bytes (pre-zip) but we would gain consistency and also get rid of that annoying caught error during bootstrap, where it says that ngLocale is missing.

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Jul 16, 2015
@petebacondarwin
refactor($locale): use en-us as generic built-in locale
137b255 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Jul 16, 2015
@petebacondarwin
refactor($locale): use en-us as generic built-in locale
bbbe107 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
@petebacondarwin petebacondarwin self-assigned this Jul 16, 2015
@petebacondarwin petebacondarwin mentioned this issue Jul 16, 2015
Merged
@petebacondarwin
Copy link
Member

I have a fix for this #12362

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Jul 16, 2015
@petebacondarwin
refactor($locale): use en-us as generic built-in locale
380ff6f 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Jul 16, 2015
@petebacondarwin
refactor($locale): use en-us as generic built-in locale
70ce425 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
20f7215 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
@lgalfaso lgalfaso mentioned this issue Jul 29, 2015
Closed
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
3632cf1 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
4846e81 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
0037fd4 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
af88220 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
83939c1 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
0b5d6ae 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit to lgalfaso/angular.js that referenced this issue Jul 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
f6677fe 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
lgalfaso added a commit that referenced this issue Jul 31, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
7b8a16b 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes #12462
Closes #12444
Closes #12134
Closes #8174
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@petebacondarwin @netman92
refactor($locale): use en-us as generic built-in locale
d6f9d21 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@lgalfaso @netman92
refactor($locale): use en-us as generic built-in locale
246c575 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12462
Closes angular#12444
Closes angular#12134
Closes angular#8174
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@petebacondarwin
refactor($locale): use en-us as generic built-in locale
86e01b2 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12134
Closes angular#8174
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@lgalfaso
refactor($locale): use en-us as generic built-in locale
84f335e 
Previously there was a custom built en-us locale that was included with
angular.js. This made likely that it would get out of sync with the real
en-us locale that is generated from the closure library.

This change removes that custom one and uses the generated one instead.
This also has the benefit of preventing the unwanted caught error on trying
to load `ngLocale` during angular bootstrap.

Closes angular#12462
Closes angular#12444
Closes angular#12134
Closes angular#8174
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petebacondarwin petebacondarwin

Labels
component: $location
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
4 participants
@petebacondarwin @matsko @lgalfaso @tdrozdz