Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(SideNav): -webkit-overflow-scrolling break position fixed behavior on IOS 13.4 Safari #19374

Closed
keatkeat87 opened this issue May 15, 2020 · 1 comment · Fixed by #30003
Closed
Labels
area: material/sidenav P4 A relatively minor issue that is not relevant to core functions

Comments

@keatkeat87
Copy link

keatkeat87 commented May 15, 2020

Reproduction

https://stackblitz.com/github/keatkeat87/angular-material-sidenav-webkit-overflow-scrolling-position-fixed-issue

Steps to reproduce:

  1. open with IPhone IOS 13.4 safari
  2. open with Android Phone
    compare two design look.

The IOS Safari look :
123123

The Android chrome look:
123123

Expected Behavior

two design should be same

Actual Behavior

the IOS Safari design is incorrect.

Some of my efforts:
I think this is due to -webkit-overflow-scrolling + position fixed, in some scene will face unexpected behavior.
refer:
https://juejin.im/post/5b6bb6a1f265da0f7b2f9228 (chinese)
https://weblog.west-wind.com/posts/2015/jun/05/ipad-scroll-issues-with-fixed-content (position:fixed and –webkit-overflow-scrolling <-- this part)

my opinion:
MDN said this is non standard and deprecated attribute.
image

so i think material should not use it by default.
image

and this solution is for fix div scroll on mobile, but currently for develop mobile app the best practice is use body scroll. because body scroll by default is momentum scroll and it is the only way to remove address bar on mobile.

please give direction for me, what should i do ?

Environment

Angular CLI: 9.1.6
Node: 12.16.1
OS: win32 x64

Angular: 9.1.7
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.901.6
@angular-devkit/build-angular 0.901.6
@angular-devkit/build-optimizer 0.901.6
@angular-devkit/build-webpack 0.901.6
@angular-devkit/core 9.1.6
@angular-devkit/schematics 9.1.6
@angular/cdk 9.2.3
@angular/cli 9.1.6
@angular/material 9.2.3
@ngtools/webpack 9.1.6
@schematics/angular 9.1.6
@schematics/update 0.901.6
rxjs 6.5.5
typescript 3.8.3
webpack 4.42.0

@keatkeat87 keatkeat87 added the needs triage This issue needs to be triaged by the team label May 15, 2020
@keatkeat87 keatkeat87 changed the title bug(SideNav): -webkit-overflow-scrolling break position fixed behavior on IOS 12 Safari bug(SideNav): -webkit-overflow-scrolling break position fixed behavior on IOS 13.4 Safari May 15, 2020
@devversion devversion added area: material/sidenav P4 A relatively minor issue that is not relevant to core functions and removed needs triage This issue needs to be triaged by the team labels May 25, 2020
mmalerba added a commit to mmalerba/components that referenced this issue Nov 12, 2024
This is a non-standard CSS property that only works on mobile Safari and
may cause inconsistent behavior by introducing a new stacking context.
Users who want this behavior can add the property themselves, but we
shouldn't specify it by default.

fixes angular#19374
mmalerba added a commit that referenced this issue Nov 13, 2024
This is a non-standard CSS property that only works on mobile Safari and
may cause inconsistent behavior by introducing a new stacking context.
Users who want this behavior can add the property themselves, but we
shouldn't specify it by default.

fixes #19374
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/sidenav P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants