-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multiple): remove webkit-overflow-scrolling #30003
Conversation
This is a non-standard CSS property that only works on mobile Safari and may cause inconsistent behavior by introducing a new stacking context. Users who want this behavior can add the property themselves, but we shouldn't specify it by default. fixes angular#19374
Given that we haven't heard about this being an issue outside of #19374 which is quite old, I'm not sure if we should do this. IIRC without it the scrolling on mobile Safari gets quite janky. |
I don't have an iOS device myself to test. But I'm kind of surprised to hear that its so janky, given that most of the web probably doesn't use this property, and it would therefore be kind of a pain to use most websites on iphone ¯\(ツ)/¯ Do you have an iOS device to give it a quick test? |
Deployed dev-app for dccabbe to: https://ng-dev-previews-comp--pr-angular-components-30003-dev-io1r1vtm.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
It sounds like it hasn't been required since safari 13: https://developer.apple.com/documentation/safari-release-notes/safari-13-release-notes#Layout-and-Rendering
|
Just tried it out and I didn't notice a difference in the dev app so I guess it's fine. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is a non-standard CSS property that only works on mobile Safari and may cause inconsistent behavior by introducing a new stacking context. Users who want this behavior can add the property themselves, but we shouldn't specify it by default.
fixes #19374