Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiple): remove webkit-overflow-scrolling #30003

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mmalerba
Copy link
Contributor

This is a non-standard CSS property that only works on mobile Safari and may cause inconsistent behavior by introducing a new stacking context. Users who want this behavior can add the property themselves, but we shouldn't specify it by default.

fixes #19374

This is a non-standard CSS property that only works on mobile Safari and
may cause inconsistent behavior by introducing a new stacking context.
Users who want this behavior can add the property themselves, but we
shouldn't specify it by default.

fixes angular#19374
@mmalerba mmalerba requested a review from a team as a code owner November 12, 2024 20:04
@mmalerba mmalerba requested review from andrewseguin and wagnermaciel and removed request for a team November 12, 2024 20:04
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 12, 2024
@crisbeto
Copy link
Member

Given that we haven't heard about this being an issue outside of #19374 which is quite old, I'm not sure if we should do this. IIRC without it the scrolling on mobile Safari gets quite janky.

@mmalerba
Copy link
Contributor Author

mmalerba commented Nov 12, 2024

I don't have an iOS device myself to test. But I'm kind of surprised to hear that its so janky, given that most of the web probably doesn't use this property, and it would therefore be kind of a pain to use most websites on iphone ¯\(ツ)

Do you have an iOS device to give it a quick test?

@mmalerba mmalerba added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 12, 2024
@mmalerba mmalerba requested a review from crisbeto November 12, 2024 20:54
Copy link

Deployed dev-app for dccabbe to: https://ng-dev-previews-comp--pr-angular-components-30003-dev-io1r1vtm.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@mmalerba
Copy link
Contributor Author

It sounds like it hasn't been required since safari 13: https://developer.apple.com/documentation/safari-release-notes/safari-13-release-notes#Layout-and-Rendering

Added support for one-finger accelerated scrolling to all frames and overflow:scroll elements eliminating the need to set-webkit-overflow-scrolling: touch.

@crisbeto
Copy link
Member

Just tried it out and I didn't notice a difference in the dev app so I guess it's fine.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 13, 2024
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 13, 2024
@mmalerba mmalerba merged commit 3a7724e into angular:main Nov 13, 2024
26 of 28 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(SideNav): -webkit-overflow-scrolling break position fixed behavior on IOS 13.4 Safari
2 participants