Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(slide-toggle): The button element contains div elements #29484

Closed
1 task
Totati opened this issue Jul 25, 2024 · 1 comment · Fixed by #29485
Closed
1 task

bug(slide-toggle): The button element contains div elements #29484

Totati opened this issue Jul 25, 2024 · 1 comment · Fixed by #29485
Assignees
Labels
area: material/slide-toggle P4 A relatively minor issue that is not relevant to core functions

Comments

@Totati
Copy link
Contributor

Totati commented Jul 25, 2024

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Button elements should contain only "Phrasing content but there must be no Interactive content"

Reproduction

Github link

Expected Behavior

divs should be replaced with span elements

Actual Behavior

The button contains invalid elements

Environment

Angular CLI: 18.0.2
Node: 18.20.3
Package Manager: yarn 1.22.19
OS: linux x64

Angular: 18.0.1
... animations, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1800.2
@angular-devkit/build-angular 18.0.2
@angular-devkit/core 18.0.2
@angular-devkit/schematics 18.0.2
@angular/cdk 18.1.2
@angular/cli 18.0.2
@angular/material 18.1.2
@angular/material-experimental 18.1.2
@angular/material-moment-adapter 18.1.2
@schematics/angular 18.0.2
rxjs 7.4.0
typescript 5.4.5
zone.js 0.14.6

@Totati Totati added the needs triage This issue needs to be triaged by the team label Jul 25, 2024
@crisbeto crisbeto self-assigned this Jul 25, 2024
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions area: material/slide-toggle and removed needs triage This issue needs to be triaged by the team labels Jul 25, 2024
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 25, 2024
Replaces `div` nodes inside the `button` with `span` since the former trigger some automated checkers.

Fixes angular#29484.
crisbeto added a commit that referenced this issue Jul 25, 2024
Replaces `div` nodes inside the `button` with `span` since the former trigger some automated checkers.

Fixes #29484.

(cherry picked from commit 1aa8512)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/slide-toggle P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants