Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slide-toggle): remove divs from button #29485

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix(material/slide-toggle): remove divs from button #29485

merged 1 commit into from
Jul 25, 2024

Conversation

crisbeto
Copy link
Member

Replaces div nodes inside the button with span since the former trigger some automated checkers.

Fixes #29484.

@crisbeto
fix(material/slide-toggle): remove divs from button
1d49922 
Replaces `div` nodes inside the `button` with `span` since the former trigger some automated checkers.

Fixes angular#29484.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 25, 2024
@crisbeto crisbeto requested a review from a team as a code owner July 25, 2024 08:51
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team July 25, 2024 08:51
@crisbeto crisbeto removed the request for review from andrewseguin July 25, 2024 20:50
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 25, 2024
@crisbeto crisbeto merged commit 1aa8512 into angular:main Jul 25, 2024
23 of 25 checks passed
crisbeto added a commit that referenced this pull request Jul 25, 2024
@crisbeto
fix(material/slide-toggle): remove divs from button (#29485)
d237e7d 
Replaces `div` nodes inside the `button` with `span` since the former trigger some automated checkers.

Fixes #29484.

(cherry picked from commit 1aa8512)
@mayankv87 mayankv87 mentioned this pull request Aug 4, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 5, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 15, 2024
Open
@rishabh114 rishabh114 mentioned this pull request Aug 22, 2024
Open
@tFaster tFaster mentioned this pull request Aug 22, 2024
Open
@kidwen kidwen mentioned this pull request Aug 22, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Aug 22, 2024
Open
@MAR-Atlantico-Rodriguez MAR-Atlantico-Rodriguez mentioned this pull request Aug 23, 2024
Open
@ambrose40 ambrose40 mentioned this pull request Aug 24, 2024
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amysorto amysorto amysorto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(slide-toggle): The button element contains div elements
2 participants
@crisbeto @amysorto