Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue: md-dialog-content on desktop #6878

Closed
Ploppy3 opened this issue Sep 6, 2017 · 3 comments · Fixed by #6890
Closed

Performance issue: md-dialog-content on desktop #6878

Ploppy3 opened this issue Sep 6, 2017 · 3 comments · Fixed by #6890
Assignees
@crisbeto

Comments

@Ploppy3
Copy link

Ploppy3 commented Sep 6, 2017 •
edited
Loading

Bug, feature request, or proposal:

Proposal

What is the expected behavior?

md-dialog-content should be optimized and should not repaint on scroll

What is the current behavior?

md-dialog-content is not optimized and repaint on scroll

What are the steps to reproduce?

image

What is the use-case or motivation for changing an existing behavior?

Angular Material has several performance issues which I think should be addressed.
The web is already slow, no need to make it any slower.
Consider using will-change: transform;

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

@angular/material: ^2.0.0-beta.10
Chrome 61
@Ploppy3 Ploppy3 changed the title md-dialog-content unoptimized on desktops Performance issue: md-dialog-conten on desktop Sep 6, 2017
@Ploppy3 Ploppy3 changed the title Performance issue: md-dialog-conten on desktop Performance issue: md-dialog-content on desktop Sep 6, 2017
@crisbeto crisbeto self-assigned this Sep 6, 2017
@crisbeto crisbeto added the has pr label Sep 6, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 6, 2017
@crisbeto
perf(dialog): avoid repaintin dialog content element on scroll
70992d5 
Fixes the `<md-dialog-content>` element being repainted on scroll.

Fixes angular#6878.
@crisbeto crisbeto mentioned this issue Sep 6, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 7, 2017
@crisbeto
perf(dialog): avoid repaintin dialog content element on scroll
f58d1b4 
Fixes the `<md-dialog-content>` element being repainted on scroll.

Fixes angular#6878.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 7, 2017
@crisbeto
perf(dialog): avoid repaintin dialog content element on scroll
bf03370 
Fixes the `<md-dialog-content>` element being repainted on scroll.

Fixes angular#6878.
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 7, 2017
@crisbeto
perf(dialog): avoid repaintin dialog content element on scroll
4e605e9 
Fixes the `<md-dialog-content>` element being repainted on scroll.

Fixes angular#6878.
@Ploppy3
Copy link
Author

Ploppy3 commented Sep 11, 2017

@crisbeto Why not use will-change: transform;?

mmalerba pushed a commit that referenced this issue Sep 12, 2017
@crisbeto @mmalerba
perf(dialog): avoid repaintin dialog content element on scroll (#6890)
51396d0 
Fixes the `<md-dialog-content>` element being repainted on scroll.

Fixes #6878.
@crisbeto
Copy link
Member

Because transform is already hardware-accelerated, it doesn't need will-change. Also will-change is supposed to be used sparingly.

josephperrott pushed a commit to josephperrott/components that referenced this issue Sep 15, 2017
@crisbeto @josephperrott
perf(dialog): avoid repaintin dialog content element on scroll (angul…
54edc28 
…ar#6890)

Fixes the `<md-dialog-content>` element being repainted on scroll.

Fixes angular#6878.
@Ploppy3 Ploppy3 mentioned this issue Sep 18, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(dialog): avoid repainting dialog content element on scroll crisbeto/material2
2 participants
@crisbeto @Ploppy3