perf(dialog): avoid repainting dialog content element on scroll #6890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 6, 2017
src/lib/dialog/dialog.scss
Outdated
| @@ -35,6 +35,9 @@ $mat-dialog-button-margin: 8px !default; | |||
| max-height: $mat-dialog-max-height; | |||
| overflow: auto; | |||
| -webkit-overflow-scrolling: touch; | |||
|
|
|||
| // Promote the content to a new GPU layer to avoid repaints on scroll. | |||
| backface-visibility: hidden; | |||
There was a problem hiding this comment.
Why was it repainting on scroll in the first place?
There was a problem hiding this comment.
Better solution to moving to GPU is transform: translate3d(0, 0, 0)
Or the will-change property is getting more support
There was a problem hiding this comment.
crisbeto
changed the title
crisbeto
force-pushed
the
6878/dialog-content-paint
branch
2 times, most recently
from
f58d1b4
to
bf03370
Compare
Fixes the `<md-dialog-content>` element being repainted on scroll. Fixes angular#6878.
crisbeto
force-pushed
the
6878/dialog-content-paint
branch
from
bf03370
to
4e605e9
Compare
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
…ar#6890) Fixes the `<md-dialog-content>` element being repainted on scroll. Fixes angular#6878.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 18, 2017
Along the same lines as angular#7721, angular#7719 and angular#6890 the tab body currently repaints on scroll.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 18, 2017
Along the same lines as angular#7721, angular#7719 and angular#6890 the tab body currently repaints on scroll.
andrewseguin
pushed a commit
that referenced
this pull request
Nov 2, 2017
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 19, 2018
A while ago we added a `backface-visibility` to some components that have scrollable content in order to avoid repaints while scrolling (see angular#7889, angular#7721, angular#7719, angular#6890, angular#2156) which worked at the time, however in the more recent versions of Chrome it causes the content in RTL mode to shift whenever a child has a transform that is being animated (in our case it's usually ripples). These changes revert the `backface-visibility` in order to avoid the jumping, until we can find a better solution.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 19, 2018
A while ago we added a `backface-visibility` to some components that have scrollable content in order to avoid repaints while scrolling (see angular#7889, angular#7721, angular#7719, angular#6890, angular#2156) which worked at the time, however in the more recent versions of Chrome it causes the content in RTL mode to shift whenever a child has a transform that is being animated (in our case it's usually ripples). These changes revert the `backface-visibility` in order to avoid the jumping, until we can find a better solution. Relates to angular#10023.
jelbourn
pushed a commit
that referenced
this pull request
Feb 26, 2018
A while ago we added a `backface-visibility` to some components that have scrollable content in order to avoid repaints while scrolling (see #7889, #7721, #7719, #6890, #2156) which worked at the time, however in the more recent versions of Chrome it causes the content in RTL mode to shift whenever a child has a transform that is being animated (in our case it's usually ripples). These changes revert the `backface-visibility` in order to avoid the jumping, until we can find a better solution. Relates to #10023.
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 26, 2018
) A while ago we added a `backface-visibility` to some components that have scrollable content in order to avoid repaints while scrolling (see angular#7889, angular#7721, angular#7719, angular#6890, angular#2156) which worked at the time, however in the more recent versions of Chrome it causes the content in RTL mode to shift whenever a child has a transform that is being animated (in our case it's usually ripples). These changes revert the `backface-visibility` in order to avoid the jumping, until we can find a better solution. Relates to angular#10023.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Feb 27, 2018
) A while ago we added a `backface-visibility` to some components that have scrollable content in order to avoid repaints while scrolling (see angular#7889, angular#7721, angular#7719, angular#6890, angular#2156) which worked at the time, however in the more recent versions of Chrome it causes the content in RTL mode to shift whenever a child has a transform that is being animated (in our case it's usually ripples). These changes revert the `backface-visibility` in order to avoid the jumping, until we can find a better solution. Relates to angular#10023.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
<md-dialog-content>element being repainted on scroll.Fixes #6878.