feat(dialog): add disableClose option #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
As mentioned in #1682, I'm thinking we should fold this into a |
crisbeto
force-pushed
the
1419/dialog-click-outside-to-close
branch
from
a9e4f6f
to
13ebd1b
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
1419/dialog-click-outside-to-close
branch
from
13ebd1b
to
3b6fa23
Compare
jelbourn
reviewed
Nov 2, 2016
| @@ -25,7 +25,7 @@ import 'rxjs/add/operator/first'; | |||
| host: { | |||
| 'class': 'md-dialog-container', | |||
| '[attr.role]': 'dialogConfig?.role', | |||
| '(keydown.escape)': 'handleEscapeKey()', | |||
There was a problem hiding this comment.
FYI: trailing commas are preferred for this repo
|
|
||
| viewContainerFixture.detectChanges(); | ||
|
|
||
| let backdrop = <HTMLElement> overlayContainerElement.querySelector('.md-overlay-backdrop'); |
There was a problem hiding this comment.
FYI, we're going to start preferring using the as HTMLElement syntax over this style cast.
(Which I still need to document in our style guide)
| let dialogContainer: MdDialogContainer = viewContainerFixture.debugElement.query( | ||
| By.directive(MdDialogContainer)).componentInstance; | ||
|
|
||
| dialogContainer.handleEscapeKey(); |
There was a problem hiding this comment.
Add this comment here as well:
// Fake the user pressing the escape key by calling the handler directly.
Adds a config option that allows users to disable closing a dialog via a backdrop click or pressing escape. Fixes angular#1419.
crisbeto
force-pushed
the
1419/dialog-click-outside-to-close
branch
from
3b6fa23
to
1a3869b
Compare
|
Addressed the latest set of notes. |
jelbourn
added
pr: lgtm
action: merge
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config option that allows users to disable closing a dialog via a backdrop click or pressing escape.
Fixes #1419.