feat(dialog): add escapeToClose config option #1682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to disable the pressing escape to close a dialog.
googlebot
added
the
cla: yes
jelbourn
reviewed
Nov 1, 2016
| @@ -14,6 +14,9 @@ export class MdDialogConfig { | |||
| /** The ARIA role of the dialog element. */ | |||
| role: DialogRole = 'dialog'; | |||
|
|
|||
| /** Whether the escape key should close the dialog. */ | |||
| escapeToClose = true; | |||
There was a problem hiding this comment.
Let's just make this disableClose and have it apply to both escape and backdrop click, since you're unlikely to want to allow one but not the other.
|
Closing in favor of combining it with #1678. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to disable the pressing escape to close a dialog.