Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/stepper): last step not being marked as interacted #17976

Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix(material/stepper): last step not being marked as interacted #17976

merged 1 commit into from
Feb 9, 2021

Conversation

crisbeto
Copy link
Member

Fixes the last step in the stepper never being marked as interacted. Also fixes some weird logic where we were changing the step state inside _anyControlsInvalidOrPending which is a getter method.

Fixes #17974.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 16, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 16, 2019
mmalerba
mmalerba approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba
Copy link
Contributor

mmalerba commented Nov 5, 2020

@crisbeto needs rebase

@crisbeto
fix(material/stepper): last step not being marked as interacted
ea77330 
Fixes the last step in the stepper never being marked as `interacted`.
Also fixes some weird logic where we were changing the step state inside
`_anyControlsInvalidOrPending` which is a getter method.

Fixes angular#17974.
@crisbeto crisbeto force-pushed the 17974/stepper-last-step-interacted branch from 0b3d6a8 to ea77330 Compare November 6, 2020 05:41
@crisbeto crisbeto changed the title fix(stepper): last step not being marked as interacted fix(material/stepper): last step not being marked as interacted Nov 6, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2020
@annieyw annieyw merged commit cd3d0e9 into angular:master Feb 9, 2021
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
fix(material/stepper): last step not being marked as interacted (#17976)
c0e2195 
Fixes the last step in the stepper never being marked as `interacted`.
Also fixes some weird logic where we were changing the step state inside
`_anyControlsInvalidOrPending` which is a getter method.

Fixes #17974.

(cherry picked from commit cd3d0e9)
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
fix(material/stepper): last step not being marked as interacted (#17976)
0d279b2 
Fixes the last step in the stepper never being marked as `interacted`.
Also fixes some weird logic where we were changing the step state inside
`_anyControlsInvalidOrPending` which is a getter method.

Fixes #17974.

(cherry picked from commit cd3d0e9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatStep.interacted is always false for last step
4 participants
@crisbeto @mmalerba @googlebot @annieyw