Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-chips): click interaction of remove icon #22132

Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix(material-experimental/mdc-chips): click interaction of remove icon #22132

merged 1 commit into from
Mar 9, 2021

Conversation

ahong11
Copy link
Contributor

@ahong11 ahong11 commented Mar 5, 2021

Fixes an issue in the mdc-chip component where clicking the remove
icon would select the chip before removing it.

@ahong11
fix(material-experimental/mdc-chips): remove icon click interaction
9ac36c1 
Fixes an issue in the `mdc-chip` component where clicking the remove
icon would select the chip before removing it.
@ahong11 ahong11 requested a review from mmalerba as a code owner March 5, 2021 16:21
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 5, 2021
mmalerba
mmalerba approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 5, 2021
crisbeto
crisbeto reviewed Mar 6, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a unit test for this? Also it would be useful to leave a comment on why the stopPropagation call is necessary.

@annieyw annieyw merged commit 0003d8f into angular:master Mar 9, 2021
annieyw pushed a commit that referenced this pull request Mar 9, 2021
@ahong11 @annieyw
fix(material-experimental/mdc-chips): remove icon click interaction (#…
4c69d18 
…22132)

Fixes an issue in the `mdc-chip` component where clicking the remove
icon would select the chip before removing it.

(cherry picked from commit 0003d8f)
This was referenced Mar 11, 2021
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahong11 @crisbeto @mmalerba @annieyw