Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-chips): click interaction of remove icon #22132

Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix(material-experimental/mdc-chips): click interaction of remove icon #22132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/material-experimental/mdc-chips/chip-icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ const _MatChipRemoveMixinBase:
mdc-chip__icon mdc-chip__icon--trailing`,
'[tabIndex]': 'tabIndex',
'role': 'button',
'(click)': 'interaction.next($event)',
'(click)': '_handleClick($event)',
'(keydown)': 'interaction.next($event)',

// We need to remove this explicitly, because it gets inherited from MatChipTrailingIcon.
Expand All @@ -196,6 +196,13 @@ export class MatChipRemove extends _MatChipRemoveMixinBase implements CanDisable
}
}

/** Emits a MouseEvent when the user clicks on the remove icon. */
_handleClick(event: MouseEvent): void {
this.interaction.next(event);

event.stopPropagation();
}

static ngAcceptInputType_disabled: BooleanInput;
static ngAcceptInputType_tabIndex: NumberInput;
}