Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customise ignore_above #773

Merged
merged 3 commits into from
Nov 27, 2016
Merged

Conversation

jeremylynch
Copy link
Contributor

As discussed in #728, 256 charters is quite restrictive and falls far short of the max of 32766 imposed by Elasticsearch.

This commit adds the ability to customize the 256 characters.

@ankane
Copy link
Owner

ankane commented Nov 22, 2016

Thanks @mrjlynch! 👍 Code looks good. As is, the readme update seems a bit confusing/inaccurate. The limit only applies to where statements and exact matches.

@jeremylynch
Copy link
Contributor Author

jeremylynch commented Nov 22, 2016

Thanks @ankane, readme is updated. Does that make it less confusing? Thanks

@jeremylynch
Copy link
Contributor Author

Would you like me to further review the readme? Thanks @ankane

@ankane
Copy link
Owner

ankane commented Nov 26, 2016

I'm still thinking this will lead to more confusion since it's most likely only relevant for a very small percentage of users. I'm happy to merge the code change, but think we should go without a readme update.

@jeremylynch
Copy link
Contributor Author

jeremylynch commented Nov 26, 2016

Hi @ankane I have removed the readme as per your advise. Thanks

@ankane ankane merged commit c482dbf into ankane:master Nov 27, 2016
@ankane
Copy link
Owner

ankane commented Nov 27, 2016

Great, thanks @mrjlynch 💯

@feliperaul
Copy link

@ankane First, congrats for this amazing project. I love searchkick.

As you can probably guess from #850, I spent an entire morning trying to understand why the exact same query would return hits only if a field was specified.

Looking at the source code I know think it's due to ignore_above param, which is set to 256 as default.

To be honest, I think readme should reflect this.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants