Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Source map with optimizations cannot be built #361

Open
arichiardi opened this issue Feb 21, 2018 · 2 comments
Open

Source map with optimizations cannot be built #361

arichiardi opened this issue Feb 21, 2018 · 2 comments

Comments

@arichiardi
Copy link
Collaborator

This bug continues to bug us 😄

git clone https://github.com/arichiardi/lumo-repros
cd lumo-repros
./scripts/build
...
{:main speed-of-light.core,
 :output-to "out/speed_of_light.js",
 :output-dir "out",
 :optimizations :advanced,
 :source-map "out/speed_of_light.js.map",
 :target :nodejs}
...
Applying optimizations :advanced to 46 sources
p.getLineCount is not a function
	 HJ (google-closure-compiler-js.cljs:7737:245)
	 l2c (google-closure-compiler-js.cljs:6713:84)
	 zHb (google-closure-compiler-js.cljs:5842:99)
	 P1c (google-closure-compiler-js.cljs:6145:152)
	 tDb (google-closure-compiler-js.cljs:5056:103)
	 iDb (google-closure-compiler-js.cljs:7117:315)
	 jDb (google-closure-compiler-js.cljs:5569:102)
	 yIb (google-closure-compiler-js.cljs:6208:201)
	 TIb (google-closure-compiler-js.cljs:7722:452)
	 (UIb.VIb)
	 jJb (google-closure-compiler-js.cljs:4846:36)
	 wIb (google-closure-compiler-js.cljs:1758:23)
	 NIb (google-closure-compiler-js.cljs:6165:148)
	 (OIb.PIb)
	 jJb (google-closure-compiler-js.cljs:4846:36)
	 sjd (google-closure-compiler-js.cljs:6538:35)
	 jjd (google-closure-compiler-js.cljs:7692:407)
	 hK (google-closure-compiler-js.cljs:1833:29)
	 kK (google-closure-compiler-js.cljs:3201:44)
	 (google-closure-compiler-js.cljs:3404:46)
	 compile (google-closure-compiler-js.cljs:8106:15)
	 Function.lumo.closure.optimize.cljs$core$IFn$_invoke$arity$variadic (evalmachine.<anonymous>:2623:123)

The @mfikes comment here is still relevant for this issue, which is a different one it seems nobody until now has reported.

@arichiardi
Copy link
Collaborator Author

See google/closure-compiler#2826

@arichiardi
Copy link
Collaborator Author

The proposed fix solves the issue 🎉

At the moment is in the google/closure-compiler#2829 but hopefully it will get included soon, in any case there is still some work to be done for the latest version (20180204) left.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant