Add SourceMapObjectParserJs.getLineCount implementation #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion It was missing but used in the no JVM version when building source maps. The implementation just returns the value of the lineCount property.
arichiardi
force-pushed
the
arichiardi/line-count-impl
branch
from
9613d26
to
9486cf9
Compare
|
I am aware of the weird branch name, I can close and reopen in case. |
|
I don't think the branch name matters. |
|
I hoped so 😉 |
sebasjm
pushed a commit
to sebasjm/closure-compiler
that referenced
this pull request
Mar 11, 2018
It was missing but used in the no JVM version when building source maps. The implementation just returns the value of the lineCount property. Fixes google#2826 Closes google#2829 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=187063993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was missing but used in the non-JVM version when building
source maps. The proposed implementation just returns the value of the
lineCount property and fixes the problem.