This repository has been archived by the owner on Jun 4, 2022. It is now read-only.
[Fix #362] Add plus to completion regex #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this fixes the issue. Can you include a test for
|
|
The fix is only for the plus, yesterday I did not have too much time and I thought that I could still contribute a simple fix. We can address the other error (that probably we should reopen) in another PR. What do you think? |
Plus test that we do the right thing.
|
Gotcha. Let's do that. I'll reopen #365 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left the forward slash out because it is a more complex case that needs more
time to tackle.