linode: Allow templating token for dynamic inventory #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Charliekenney23 @InTheCloudDan @LBGarber @decentral1se @displague @rmcintosh |
ansibullbot
added
cloud
feature
wbh1
force-pushed
the
linode/inventory-templating
branch
from
7fb1f3e
to
2bd73ca
Compare
ansibullbot
added
tests
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment?
felixfontein
added
backport-4
check-before-release
Template the value for the access_token if it's a Jinja template. Allows for looking up tokens from files or pulling from secrets stores like Vault.
wbh1
force-pushed
the
linode/inventory-templating
branch
from
2bd73ca
to
90feee1
Compare
wbh1
force-pushed
the
linode/inventory-templating
branch
from
90feee1
to
57a9d96
Compare
Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
added
needs_ci
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Jan 19, 2022
|
If nobody complains until beginning of next week, I'll merge this PR by then. |
felixfontein
removed
the
check-before-release
|
Looks like I missed the beginning of last week, so let's merge it now :) |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4119 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 30, 2022
* linode: Allow templating token for dynamic inventory Template the value for the access_token if it's a Jinja template. Allows for looking up tokens from files or pulling from secrets stores like Vault. * add Linode changelog fragment * Fix lookup example for newer versions of Ansible Co-authored-by: Felix Fontein <felix@fontein.de> * Rename test case for clarity Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit f77a111)
|
@wbh1 thanks for contributing this! |
felixfontein
pushed a commit
that referenced
this pull request
Jan 30, 2022
* linode: Allow templating token for dynamic inventory Template the value for the access_token if it's a Jinja template. Allows for looking up tokens from files or pulling from secrets stores like Vault. * add Linode changelog fragment * Fix lookup example for newer versions of Ansible Co-authored-by: Felix Fontein <felix@fontein.de> * Rename test case for clarity Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit f77a111) Co-authored-by: Will Hegedus <will@wbhegedus.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Template the value for the
access_tokenif it's a Jinja template.Allows for looking up tokens from files or pulling from secrets stores like Vault.
ISSUE TYPE
COMPONENT NAME
linode
ADDITIONAL INFORMATION
This is inspired by how AWS handles templating in their EC2 dynamic inventory plugin.