Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #4040/f77a1114 backport][stable-4] linode: Allow templating token for dynamic inventory #4119

Merged
merged 1 commit into from
Jan 30, 2022
Merged

[PR #4040/f77a1114 backport][stable-4] linode: Allow templating token for dynamic inventory #4119

merged 1 commit into from
Jan 30, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jan 30, 2022

This is a backport of PR #4040 as merged into main (f77a111).

SUMMARY

Template the value for the access_token if it's a Jinja template.

Allows for looking up tokens from files or pulling from secrets stores like Vault.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

linode

ADDITIONAL INFORMATION

This is inspired by how AWS handles templating in their EC2 dynamic inventory plugin.

@wbh1 @patchback
linode: Allow templating token for dynamic inventory (#4040)
368756c 
* linode: Allow templating token for dynamic inventory

Template the value for the access_token if it's a Jinja template.

Allows for looking up tokens from files or pulling from secrets stores like Vault.

* add Linode changelog fragment

* Fix lookup example for newer versions of Ansible

Co-authored-by: Felix Fontein <felix@fontein.de>

* Rename test case for clarity

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit f77a111)
@patchback patchback bot mentioned this pull request Jan 30, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @Charliekenney23 @InTheCloudDan @LBGarber @decentral1se @displague @rmcintosh
click here for bot help

@ansibullbot ansibullbot added backport cloud feature This issue/PR relates to a feature request inventory inventory plugin needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit labels Jan 30, 2022
@felixfontein felixfontein merged commit db84ea4 into stable-4 Jan 30, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/f77a1114fb1bfb90bbde7851fc8b1959c6dafd3e/pr-4040 branch January 30, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cloud feature This issue/PR relates to a feature request inventory inventory plugin needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @wbh1