Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add action_group and check_mode attributes #320

Merged
merged 7 commits into from
Nov 5, 2022
Merged

add action_group and check_mode attributes #320

merged 7 commits into from
Nov 5, 2022

Conversation

briantist
Copy link
Collaborator

SUMMARY

Resolves #197

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request

@briantist briantist added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 3, 2022
@briantist briantist added this to the v3.4.0 milestone Nov 3, 2022
@briantist briantist self-assigned this Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hashi_vault/branch/main

@codecov
Copy link

codecov bot commented Nov 3, 2022 •
edited
Loading

Codecov Report

Merging #320 (2811949) into main (75e4c59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   98.72%   98.73%           
=======================================
  Files          75       76    +1     
  Lines        3854     3860    +6     
  Branches      252      252           
=======================================
+ Hits         3805     3811    +6     
  Misses         40       40           
  Partials        9        9
Flag Coverage Δ
env_docker-default 98.73% <100.00%> (+<0.01%) ⬆️
integration 81.08% <ø> (ø)
sanity 39.26% <100.00%> (+0.25%) ⬆️
target_ansible-doc 100.00% <100.00%> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_azure 53.84% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.07% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 83.30% <ø> (ø)
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.26% <100.00%> (+0.25%) ⬆️
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 55.87% <ø> (ø)
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.66% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 79.24% <ø> (ø)
target_lookup_vault_write 57.57% <ø> (ø)
target_module_utils 97.08% <ø> (ø)
target_module_vault_kv1_get 87.50% <ø> (ø)
target_module_vault_kv2_delete 57.14% <ø> (ø)
target_module_vault_kv2_get 87.23% <ø> (ø)
target_module_vault_login 83.72% <ø> (ø)
target_module_vault_pki_generate_certificate 78.72% <ø> (ø)
target_module_vault_read 85.71% <ø> (ø)
target_module_vault_token_create 91.66% <ø> (ø)
target_module_vault_write 56.46% <ø> (ø)
target_modules 80.51% <ø> (ø)
units 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/vault_kv1_get.py 100.00% <ø> (ø)
plugins/modules/vault_kv2_delete.py 100.00% <ø> (ø)
plugins/modules/vault_kv2_get.py 100.00% <ø> (ø)
plugins/modules/vault_login.py 100.00% <ø> (ø)
plugins/modules/vault_pki_generate_certificate.py 95.74% <ø> (ø)
plugins/modules/vault_read.py 100.00% <ø> (ø)
plugins/modules/vault_token_create.py 100.00% <ø> (ø)
plugins/modules/vault_write.py 100.00% <ø> (ø)
plugins/doc_fragments/attributes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@briantist briantist modified the milestones: v3.4.0, v4.0.0 Nov 3, 2022
@felixfontein
Copy link
Contributor

ansible-community/antsibull-docs#62 will fix rendering this.

@felixfontein
Copy link
Contributor

The antsibull-docs PR is merged and antsibull-docs 1.7.3 released.

@briantist @felixfontein
Update plugins/doc_fragments/action_group.py
44053d3 
Co-authored-by: Felix Fontein <felix@fontein.de>
@briantist briantist marked this pull request as draft November 4, 2022 20:46
@felixfontein
Copy link
Contributor

Looks much better now: https://ansible-collections.github.io/community.hashi_vault/pr/320/collections/community/hashi_vault/vault_kv1_get_module.html#attributes

@briantist briantist changed the title add action_group attribute add action_group and check_mode attributes Nov 4, 2022
@briantist briantist added this to the v4.0.0 milestone Nov 4, 2022
@briantist briantist marked this pull request as ready for review November 4, 2022 22:24
@briantist briantist mentioned this pull request Nov 5, 2022
Closed
@briantist
Copy link
Collaborator Author

@felixfontein thanks for reviewing and putting in that fix to antsibull-docs so quickly!

@briantist briantist merged commit 2afac56 into ansible-collections:main Nov 5, 2022
@briantist briantist deleted the modules/attributes branch November 5, 2022 20:21
@briantist briantist mentioned this pull request Nov 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees

@briantist briantist

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

consider adding "attributes" to collection content
2 participants
@briantist @felixfontein