Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering of action_group #62

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Fix rendering of action_group #62

merged 4 commits into from
Nov 4, 2022

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein mentioned this pull request Nov 4, 2022
Merged
@felixfontein felixfontein marked this pull request as ready for review November 4, 2022 06:42
@felixfontein
Copy link
Collaborator Author

See https://ansible.fontein.de/collections/community/hashi_vault/vault_kv1_get_module.html#attributes for the result.

briantist
briantist approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this fix!

Only thing I might consider is adding a test with > 1 group.

@felixfontein felixfontein merged commit 056d9d6 into ansible-community:main Nov 4, 2022
@felixfontein felixfontein deleted the action_group branch November 4, 2022 19:58
@felixfontein
Copy link
Collaborator Author

@briantist thanks a lot for reviewing this!

@samccann samccann mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @briantist