Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CI #112

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

zhan9san
Copy link
Member

@zhan9san zhan9san commented Mar 16, 2023

  1. Fix typo
  2. Install collection from galaxy, it's a simply way to install collection
  3. Use ansible installed by tox and remove apt-get install ansible

Related to #111 (comment)

@zhan9san zhan9san added bug Something isn't working skip-changelog labels Mar 16, 2023
@zhan9san zhan9san marked this pull request as draft March 16, 2023 15:24
@zhan9san zhan9san force-pushed the feature/fix-ci-issue branch from acbf805 to 87b05f8 Compare March 17, 2023 09:46
@zhan9san zhan9san changed the title Install collection from galaxy Optimize CI Mar 17, 2023
@zhan9san zhan9san marked this pull request as ready for review March 17, 2023 10:35
@zhan9san zhan9san requested review from ssbarnea, apatard and a team March 17, 2023 11:18
@ssbarnea ssbarnea merged commit 7b7cb0e into ansible-community:main Mar 17, 2023
dankow pushed a commit to dankow/molecule-plugins that referenced this pull request Mar 31, 2023
Install collection from galaxy, fix typo, do not install ansible via apt-get
ssbarnea added a commit that referenced this pull request Apr 5, 2023
* Docker: Add support for `platform` parameter

Pass `platform` value from `platforms.item` to `docker_container`. Example usage:
```
driver:
  name: docker
platforms:
  - name: test-01
    image: ...
    pre_build_image: true
    platform: linux/amd64
```

As suggested in the [docker_container documentation](https://docs.ansible.com/ansible/latest/collections/community/docker/docker_container_module.html#ansible-collections-community-docker-docker-container-module), ignore the `platform` parameter when comparing state.

Addresses issue #94.

* Trigger checks

* Fix ci issue (#111)

* Fix ci issue

* fix ci

* Optimize CI (#112)

Install collection from galaxy, fix typo, do not install ansible via apt-get

* README.md: Update plugin list (#91)

With newly added plugins, the list has to be updated.

Signed-off-by: Arnaud Patard <apatard@hupstream.com>

* Perform linting on Ansible playbooks (#101)

* skip experimental rules

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

* Lint ansible files

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

* fix missed alignment

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

* Fix blk100 flake8 errors

Flake8 is giving errors about some empty lines in the code, so
remove the line to fix these errors.

Signed-off-by: Arnaud Patard <apatard@hupstream.com>

---------

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Co-authored-by: Arnaud Patard <apatard@hupstream.com>

* [pre-commit.ci] pre-commit autoupdate (#93)

updates:
- [github.com/psf/black: 22.12.0 → 23.1.0](psf/black@22.12.0...23.1.0)
- [github.com/ansible/ansible-lint.git: v6.10.2 → v6.14.2](https://github.com/ansible/ansible-lint.git/compare/v6.10.2...v6.14.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* install python3 only when ansible_system == Linux (#110)

* assume windows when ansible_connection is winrm

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

* replace raw: with package:

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

* revert back to raw

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

* use uname to check if it's a Linux system

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

---------

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

* Make selinux an optional extra (#89)

As our special selinux shim dependency also caused problems for
people that did not really need selinux, we now make it a simple
extra.

* Trigger checks

---------

Signed-off-by: Arnaud Patard <apatard@hupstream.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Co-authored-by: Jack <jack4zhang@gmail.com>
Co-authored-by: Arnaud Patard <apatard@hupstream.com>
Co-authored-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants