-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make selinux an optional extra #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As our special selinux shim dependency also caused problems for people that did not really need selinux, we now make it a simple extra.
apatard
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what would be the possible breakages of this change but I remember having an issue with python-selinux in the past (can't remember what it was). So, this sounds a good idea to me.
dankow
pushed a commit
to dankow/molecule-plugins
that referenced
this pull request
Mar 31, 2023
As our special selinux shim dependency also caused problems for people that did not really need selinux, we now make it a simple extra.
ssbarnea
added a commit
that referenced
this pull request
Apr 5, 2023
* Docker: Add support for `platform` parameter Pass `platform` value from `platforms.item` to `docker_container`. Example usage: ``` driver: name: docker platforms: - name: test-01 image: ... pre_build_image: true platform: linux/amd64 ``` As suggested in the [docker_container documentation](https://docs.ansible.com/ansible/latest/collections/community/docker/docker_container_module.html#ansible-collections-community-docker-docker-container-module), ignore the `platform` parameter when comparing state. Addresses issue #94. * Trigger checks * Fix ci issue (#111) * Fix ci issue * fix ci * Optimize CI (#112) Install collection from galaxy, fix typo, do not install ansible via apt-get * README.md: Update plugin list (#91) With newly added plugins, the list has to be updated. Signed-off-by: Arnaud Patard <apatard@hupstream.com> * Perform linting on Ansible playbooks (#101) * skip experimental rules Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * Lint ansible files Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * fix missed alignment Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * Fix blk100 flake8 errors Flake8 is giving errors about some empty lines in the code, so remove the line to fix these errors. Signed-off-by: Arnaud Patard <apatard@hupstream.com> --------- Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> Signed-off-by: Arnaud Patard <apatard@hupstream.com> Co-authored-by: Arnaud Patard <apatard@hupstream.com> * [pre-commit.ci] pre-commit autoupdate (#93) updates: - [github.com/psf/black: 22.12.0 → 23.1.0](psf/black@22.12.0...23.1.0) - [github.com/ansible/ansible-lint.git: v6.10.2 → v6.14.2](https://github.com/ansible/ansible-lint.git/compare/v6.10.2...v6.14.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * install python3 only when ansible_system == Linux (#110) * assume windows when ansible_connection is winrm Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * replace raw: with package: Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * revert back to raw Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * use uname to check if it's a Linux system Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> --------- Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * Make selinux an optional extra (#89) As our special selinux shim dependency also caused problems for people that did not really need selinux, we now make it a simple extra. * Trigger checks --------- Signed-off-by: Arnaud Patard <apatard@hupstream.com> Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> Co-authored-by: Jack <jack4zhang@gmail.com> Co-authored-by: Arnaud Patard <apatard@hupstream.com> Co-authored-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our special selinux shim dependency also caused problems for people that did not really need selinux, we now make it a simple extra.