Split Copier into Walker and Copier steps #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qalthos
force-pushed
the
less-destructive
branch
from
8765afe to
690a7f3
Compare
Qalthos
commented
Sep 23, 2024
cidrblock
requested changes
Sep 23, 2024
Qalthos
force-pushed
the
less-destructive
branch
5 times, most recently
from
4c88051 to
4db1c94
Compare
Qalthos
requested review from
shatakshiiii,
tanwigeetika1618 and
cidrblock
and removed request for
a team
Qalthos
force-pushed
the
less-destructive
branch
4 times, most recently
from
250ab17 to
d4715ba
Compare
cidrblock
approved these changes
Sep 27, 2024
shatakshiiii
approved these changes
Sep 27, 2024
cidrblock
reviewed
Sep 27, 2024
cidrblock
reviewed
Sep 27, 2024
Co-authored-by: Bradley A. Thornton <bthornto@redhat.com>
Qalthos
force-pushed
the
less-destructive
branch
from
3dad8f6 to
7a02542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walker recursively looks for paths that need to be copied over, and returns a list of destination/original path objects
Copier takes that list and does the actual copying.
Notes:
meta handling is broken right now, I forgot about ittests have not been touched yet--forceis currently a no-op.gitignore's meta is not getting applied correctly--forcereinstated, there is no good way to access the file conflict handling of CopierOpen Questions:
Related issue: #163