Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Copier into Walker and Copier steps #294

Merged
merged 11 commits into from
Sep 27, 2024
Merged

Split Copier into Walker and Copier steps #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0d1b86c
Split Copier into Walker and Copier steps
Qalthos Sep 20, 2024
736784d
Strip a lot back from DestinationFile
Qalthos Sep 20, 2024
49eb3e7
Carry (potentially modified) template_data with src and dest
Qalthos Sep 23, 2024
95ba126
Clear up per-file debug lines
Qalthos Sep 23, 2024
e9af343
Add test for Copier overwriting files
Qalthos Sep 23, 2024
42d5409
Be a little more explicit about what those test paths should be
Qalthos Sep 23, 2024
33d790b
Also take templating away from Copier's responsibilities
Qalthos Sep 25, 2024
e63832a
Walker now only returns path that need changes to be applied.
Qalthos Sep 25, 2024
01c949b
Cache DestinationFile properties and provide container class
Qalthos Sep 27, 2024
c2450bc
Test has_conflicts in FileList
Qalthos Sep 27, 2024
7a02542
Update src/ansible_creator/utils.py
Qalthos Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/ansible_creator/subcommands/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from ansible_creator.exceptions import CreatorError
from ansible_creator.templar import Templar
from ansible_creator.types import TemplateData
from ansible_creator.utils import Copier
from ansible_creator.utils import Copier, Walker


if TYPE_CHECKING:
Expand Down Expand Up @@ -125,14 +125,19 @@ def _scaffold(self) -> None:
dev_file_name=self.unique_name_in_devfile(),
)

copier = Copier(
resources=[f"{self._project}_project", *self.common_resources],
walker = Walker(
resources=(f"{self._project}_project", *self.common_resources),
resource_id=f"{self._project}_project",
dest=self._init_path,
output=self.output,
templar=self._templar,
template_data=template_data,
)
copier.copy_containers()
paths = walker.collect_paths()

copier = Copier(
output=self.output,
)
copier.copy_containers(paths)

self.output.note(f"{self._project} project created at {self._init_path}")
Loading
Loading