Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made yamllint a direct dependency #1881

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Feb 12, 2022

This makes the linter execution more predictable, avoiding divergence in behavior based on yamllint presence or absence.

Fixes: #1735
Depends-On: #1880

@ssbarnea ssbarnea added the major Used for release notes, requires major versioning bump label Feb 12, 2022
@ssbarnea ssbarnea requested a review from tadeboro February 12, 2022 15:52
@github-actions github-actions bot added the skip-changelog Can be missed from the changelog. label Feb 12, 2022
@ssbarnea ssbarnea requested a review from cidrblock February 12, 2022 15:52
This makes the linter execution more predictable, avoiding divergence
in behavior based on yamllint presence or absence.

Fixes: ansible#1735
@ssbarnea ssbarnea removed the skip-changelog Can be missed from the changelog. label Feb 13, 2022
@ssbarnea ssbarnea marked this pull request as ready for review February 13, 2022 09:41
@ssbarnea ssbarnea requested a review from a team as a code owner February 13, 2022 09:41
@ssbarnea ssbarnea requested review from ganeshrn and priyamsahoo and removed request for a team February 13, 2022 09:41
@ssbarnea ssbarnea changed the title Made yamllint a direct dependency (GPL) Made yamllint a direct dependency Feb 13, 2022
@ssbarnea ssbarnea requested a review from webknjaz February 13, 2022 09:55
@ssbarnea ssbarnea merged commit 36e1b1e into ansible:main Feb 13, 2022
@ssbarnea ssbarnea deleted the fix/v6-yamllint branch February 13, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Used for release notes, requires major versioning bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yamllint soft-dependency should be removed
2 participants