Clarify GPLv3 license of the distribution #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested review from
relrod,
ganeshrn and
priyamsahoo
and removed request for
a team
ssbarnea
force-pushed
the
fix/v6-license
branch
2 times, most recently
from
0320515 to
e974c3a
Compare
cidrblock
approved these changes
Feb 13, 2022
tadeboro
approved these changes
Feb 14, 2022
webknjaz
reviewed
Feb 14, 2022
ssbarnea
force-pushed
the
fix/v6-license
branch
from
318221e to
562b46d
Compare
I prefer to be explicit here. I also see @cidrblock did the same on https://github.com/ansible/ansible-navigator/tree/main/licenses |
webknjaz
reviewed
Feb 14, 2022
- Ensure that GitHub advertises the project as GPLv3 in order to avoid misleading some users by adding COPYING file, matching ansible repository. - Keep MIT status for its own-source code and future contributions - Ensure that pypi metadata lists only GPLv3 as a license because the distribution includes direct GPL dependencies. - From the technical point of view that involved move of MIT license file from /LICENSE to `docs/licenses/LICENSE.mit.txt`. We tried to keep both licenses at repository root buy this is breaking GitHub licensing detection heuristic and prevents it from displaying "GPLv3" license hyperlink on the right sidebar, which was the main source of confusions so far. This is not a relicensing of the project and should be seen as an esthetic change aimed to clarify recurring confusions. The need to do this now is more important as we are going to make both ansible-core and yamllint direct runtime dependencies.
ssbarnea
force-pushed
the
fix/v6-license
branch
from
562b46d to
6b881bb
Compare
webknjaz
reviewed
Feb 14, 2022
webknjaz
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/LICENSEtodocs/licenses/LICENSE.MIT.txt. We tried to keep both licenses at repository root buy this is breaking GitHub licensing detection heuristic and prevents it from displaying "GPLv3" license hyperlink on the right sidebar, which was the main source of confusions so far.GPLv3+instead ofGPLv3, while Ansible itself is onlyGPLv3, so the plus clause does not apply.This is not a relicensing of the project and should be seen as an esthetic change aimed to clarify recurring confusions. The need to do this now is more important as we made
ansible-coreand yamllint direct dependencies via #1888 and #1881.Please read #1832 for more details.