Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from prerun submodule #1971

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Remove unused code from prerun submodule #1971

merged 1 commit into from
Mar 10, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 10, 2022 •
edited
Loading

Removes all the code that is no longer used from prerun. We will do a follow-up to rename
the module to _mockings after that, as that is all it remained. All the removed code
exists in ansible-compat project.

@ssbarnea ssbarnea requested a review from a team as a code owner March 10, 2022 17:30
@ssbarnea ssbarnea requested review from relrod, ganeshrn and priyamsahoo and removed request for a team March 10, 2022 17:30
@ssbarnea ssbarnea changed the title rm/prerun Remove unused code from prerun submodule Mar 10, 2022
@ssbarnea ssbarnea added the major Used for release notes, requires major versioning bump label Mar 10, 2022
@ssbarnea ssbarnea requested a review from cognifloyd March 10, 2022 17:32
@ssbarnea ssbarnea enabled auto-merge (squash) March 10, 2022 17:53
@ssbarnea ssbarnea merged commit 256d79a into ansible:main Mar 10, 2022
@ssbarnea ssbarnea mentioned this pull request Mar 10, 2022
Merged
@ssbarnea ssbarnea mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

@relrod relrod Awaiting requested review from relrod relrod was automatically assigned from ansible-community/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
major Used for release notes, requires major versioning bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @cognifloyd