Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove html extension from documentation #1981

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Remove html extension from documentation #1981

merged 1 commit into from
Mar 14, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 12, 2022 •
edited
Loading

Makes URLs nicer by using dirhtml build instead of html. The effect
is that you will no longer see .html as part of URLs.

@ssbarnea ssbarnea requested a review from a team as a code owner March 12, 2022 07:43
@ssbarnea ssbarnea requested review from webknjaz, ganeshrn and priyamsahoo and removed request for a team March 12, 2022 07:43
@ssbarnea ssbarnea changed the title fix/docs no extension Remove html extension from documentation Mar 12, 2022
@github-actions github-actions bot added the bug label Mar 12, 2022
@ssbarnea ssbarnea force-pushed the fix/docs-no-extension branch 2 times, most recently from 04c83eb to 972bcf0 Compare March 12, 2022 07:56
@ssbarnea ssbarnea removed the bug label Mar 12, 2022
webknjaz
webknjaz suggested changes Mar 12, 2022
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes are fine but these things below must be fixed before merging.

tox.ini Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
@ssbarnea ssbarnea force-pushed the fix/docs-no-extension branch 2 times, most recently from 0adaad7 to c1d5d2e Compare March 14, 2022 16:20
@ssbarnea
Remove html extension from documentation
391aefa 
Makes URLs nicer by using dirhtml build instead of html. The effect
is that you will no longer see .html as part of URLs.
@ssbarnea ssbarnea force-pushed the fix/docs-no-extension branch from 175a36f to 391aefa Compare March 14, 2022 16:25
@ssbarnea ssbarnea merged commit 64dbe52 into ansible:main Mar 14, 2022
@ssbarnea ssbarnea mentioned this pull request Mar 14, 2022
Merged
@ssbarnea ssbarnea deleted the fix/docs-no-extension branch March 15, 2022 11:49
@ssbarnea ssbarnea mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz requested changes

@cognifloyd cognifloyd cognifloyd approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssbarnea @webknjaz @cognifloyd