Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full access for staff members #602

Merged

Conversation

chouseknecht
Copy link
Contributor

@chouseknecht chouseknecht commented May 30, 2018

API changes to allow user's with is_staff full access to create/update/delete Namespace, Provider Namespace and Repository objects.

Plus:

  • Add description to content_objects returned by Repository serializer

Issue #433

@chouseknecht chouseknecht force-pushed the feature/api-namespace-access branch from 5b5fe4c to 2e7c730 Compare June 3, 2018 01:39
@chouseknecht chouseknecht changed the title [WIP] Full access for staff members Full access for staff members Jun 3, 2018
Copy link
Collaborator

@cutwater cutwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the part where this patch fixes loaders (not related to PR title) it looks good to me.

@chouseknecht chouseknecht force-pushed the feature/api-namespace-access branch from 7052cb8 to 4529144 Compare June 4, 2018 18:08
@@ -54,6 +54,7 @@ def get(self, request, *args, **kwargs):
'id': provider.pk,
'name': provider.name.lower()
}
print(source['name'])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove debug print.

@chouseknecht chouseknecht force-pushed the feature/api-namespace-access branch from 4529144 to 1678a73 Compare June 5, 2018 18:49
@chouseknecht chouseknecht dismissed cutwater’s stale review June 5, 2018 18:49

All fixed. Thanks!

@chouseknecht chouseknecht merged commit 5b074bf into ansible:release/3.0 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants