-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI changes for allowing staff full access to Namespace #603
UI changes for allowing staff full access to Namespace #603
Conversation
6301472
to
4ac8d53
Compare
@@ -42,6 +42,9 @@ | |||
|
|||
|
|||
def check_provider_access(provider, user, name): | |||
if user.is_staff: | |||
return True | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check_provider_access() checks this itself but check_namespace_access() doesnt.
Any particular reason?
Nothing seems to use the return of this method, does it need to 'return True' or could it just 'return' ?
3fbf944
to
11036e4
Compare
Thanks for pointing out my hackery. Turns out there isn't any need to check |
5d50068
to
00aaec5
Compare
UI changes to allow user's with
is_staff
full access to create/update/delete Namespace, Provider Namespace and Repository objects.install
command appears.Issue #433
Requires #602