Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI changes for allowing staff full access to Namespace #603

Merged

Conversation

chouseknecht
Copy link
Contributor

@chouseknecht chouseknecht commented May 30, 2018

UI changes to allow user's with is_staff full access to create/update/delete Namespace, Provider Namespace and Repository objects.

  • Upgraded to latest patternfly and latest Ng CLI tool.
  • On Search page, added sort by fork count
  • Added fork count to Search results
  • Created a Copy-n-Paste component, and applied it anywhere an install command appears.
  • Fixed at least one thing causing a performance issue on My Content

Issue #433
Requires #602

@chouseknecht chouseknecht changed the title Allow staff full access to Namespace [WIP] Allow staff full access to Namespace May 30, 2018
@chouseknecht chouseknecht changed the title [WIP] Allow staff full access to Namespace [WIP] UI changes for allowing staff full access to Namespace May 30, 2018
@chouseknecht chouseknecht force-pushed the feature/namespace-access branch from 6301472 to 4ac8d53 Compare May 30, 2018 13:26
@@ -42,6 +42,9 @@


def check_provider_access(provider, user, name):
if user.is_staff:
return True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_provider_access() checks this itself but check_namespace_access() doesnt.
Any particular reason?

Nothing seems to use the return of this method, does it need to 'return True' or could it just 'return' ?

@chouseknecht chouseknecht force-pushed the feature/namespace-access branch from 3fbf944 to 11036e4 Compare June 3, 2018 01:32
@chouseknecht
Copy link
Contributor Author

@alikins

Thanks for pointing out my hackery. Turns out there isn't any need to check is_staff on Provider Namespace. In the UI, the user modifies Namespace and Repositories, and Provider Namespace gets created and modified indirectly by the server. Reverted the change.

@chouseknecht chouseknecht changed the title [WIP] UI changes for allowing staff full access to Namespace UI changes for allowing staff full access to Namespace Jun 3, 2018
@chouseknecht chouseknecht force-pushed the feature/namespace-access branch from 5d50068 to 00aaec5 Compare June 5, 2018 19:47
@chouseknecht chouseknecht merged commit 1de9cca into ansible:release/3.0 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants