Add 'halt' option to vagrant module #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this functionality already exist? |
|
hey @retr0h !! technically the section you highlighted already performs a halt but then immediately afterwards it performs a destroy if self._module.params['force_stop']:
self._vagrant.halt(force=True)
self._vagrant.destroy()I just want the halt functionality without destroying the machine. Hope that makes more sense. |
msheiny
added a commit
to freedomofpress/securedrop
that referenced
this pull request
Apr 7, 2018
See PR ansible/molecule#1233. Before we package up the vagrant machine into a box, we need to shutdown the vagrant box. The built-in molecule module only had `up` or `destroy`. *fingers-crossed* this gets in upstream and we can tear this out.
|
@msheiny oh yeah, I see. Can you update the module docs and add an example. |
berendt
reviewed
Apr 9, 2018
| def halt(self): | ||
| changed = False | ||
| cd = self._created() | ||
| if cd: |
There was a problem hiding this comment.
Thats a good observation @berendt ... I'd like to keep my PR pretty lean though and since that paradigm is already used throughout the file. I think filing a different PR to cleanup that specific logic would be a better course of action.
There was a problem hiding this comment.
@msheiny Have not checked the rest of the file. if it is used everywhere else it fits.
msheiny
added a commit
to freedomofpress/securedrop
that referenced
this pull request
Apr 9, 2018
See PR ansible/molecule#1233. Before we package up the vagrant machine into a box, we need to shutdown the vagrant box. The built-in molecule module only had `up` or `destroy`. *fingers-crossed* this gets in upstream and we can tear this out.
|
updated @retr0h ! 👍 |
|
Thanks @msheiny ! |
msheiny
added a commit
to freedomofpress/securedrop
that referenced
this pull request
Apr 30, 2018
See PR ansible/molecule#1233. Before we package up the vagrant machine into a box, we need to shutdown the vagrant box. The built-in molecule module only had `up` or `destroy`. *fingers-crossed* this gets in upstream and we can tear this out.
msheiny
added a commit
to freedomofpress/securedrop
that referenced
this pull request
May 3, 2018
See PR ansible/molecule#1233. Before we package up the vagrant machine into a box, we need to shutdown the vagrant box. The built-in molecule module only had `up` or `destroy`. *fingers-crossed* this gets in upstream and we can tear this out.
msheiny
added a commit
to freedomofpress/securedrop
that referenced
this pull request
May 7, 2018
See PR ansible/molecule#1233. Before we package up the vagrant machine into a box, we need to shutdown the vagrant box. The built-in molecule module only had `up` or `destroy`. *fingers-crossed* this gets in upstream and we can tear this out.
msheiny
added a commit
to freedomofpress/securedrop
that referenced
this pull request
May 7, 2018
Our unique changes that were added to support suppressing NFS were recently merged upstream in molecule 2.13: * ansible/molecule#1235 * ansible/molecule#1233
msheiny
added a commit
to freedomofpress/securedrop
that referenced
this pull request
May 7, 2018
Our unique changes that were added to support suppressing NFS were recently merged upstream in molecule 2.13: * ansible/molecule#1235 * ansible/molecule#1233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
haltoption tostateto shut-down a VM without deleting it.