Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter for vagrant provider override #1235

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

msheiny
Copy link
Contributor

@msheiny msheiny commented Apr 6, 2018

See the docs for additional info on this option:
https://www.vagrantup.com/docs/providers/configuration.html#overriding-configuration

While trying to disable nfs explicitly on a box that had it enabled... doing an over-ride on the provider was the only way I could get it working 🤷‍♂️ This might be a libvirt specific problem but adding this option fixed it for me and its optional.

@msheiny msheiny force-pushed the AllowVagrantOverride branch from 2ded2b4 to 4bbb580 Compare April 6, 2018 20:49
msheiny added a commit to freedomofpress/securedrop that referenced this pull request Apr 7, 2018
Made a PR upstream at ansible/molecule#1235.
This was needed in order to disable nfs completely under libvirt for
some reason.
@retr0h
Copy link
Contributor

retr0h commented Apr 7, 2018

@msheiny can you provide more information, specifically usage of your new option.

msheiny added a commit to freedomofpress/securedrop that referenced this pull request Apr 9, 2018
Made a PR upstream at ansible/molecule#1235.
This was needed in order to disable nfs completely under libvirt for
some reason.
@msheiny
Copy link
Contributor Author

msheiny commented Apr 10, 2018

sureeeeeeeee @retr0h i'm specifically using it in this scenario:

molecule.yml:

driver:
  name: vagrant
  provider:
    name: libvirt
platforms:
  - name: app-staging
    box: fpf/securedrop-app
    box_url: "../vagrant_packager/box_files/app_metadata.json"
    box_version: "0.6"
    instance_raw_config_args:
      - "ssh.insert_key = false"
    provider_override_args:
      - "vm.synced_folder './', '/vagrant', disabled: true, type: 'nfs'"
    memory: 1024
    private_ip: 10.0.1.2
    groups:
      - securedrop_application_server
      - securedrop
      - staging

I'm trying to disable synced folder mapping and NFS for the underlying box. No matter where else I try to put the NFS value I was unable to stop vagrant from bombing out without sticking it under the override key.

@retr0h
Copy link
Contributor

retr0h commented Apr 25, 2018

Thanks @msheiny can you add this example to https://github.com/metacloud/molecule/blob/master/doc/source/configuration.rst#molecule-vagrant-module ? I'll release 2.13 once your PR is complete.

@retr0h retr0h added the v2.13 label Apr 25, 2018
@retr0h retr0h merged commit aea2c7c into ansible:master Apr 27, 2018
@retr0h
Copy link
Contributor

retr0h commented Apr 27, 2018

Thanks @msheiny can you add this example to https://github.com/metacloud/molecule/blob/master/doc/source/configuration.rst#molecule-vagrant-module ? I'll release 2.13 once your PR is complete.

I'll do this.

@retr0h
Copy link
Contributor

retr0h commented Apr 27, 2018

Will this disable folder syncing, if adding to platforms section?

config_options:
  synced_folder: False

msheiny added a commit to freedomofpress/securedrop that referenced this pull request Apr 30, 2018
Made a PR upstream at ansible/molecule#1235.
This was needed in order to disable nfs completely under libvirt for
some reason.
msheiny added a commit to freedomofpress/securedrop that referenced this pull request May 3, 2018
Made a PR upstream at ansible/molecule#1235.
This was needed in order to disable nfs completely under libvirt for
some reason.
msheiny added a commit to freedomofpress/securedrop that referenced this pull request May 7, 2018
Made a PR upstream at ansible/molecule#1235.
This was needed in order to disable nfs completely under libvirt for
some reason.
msheiny added a commit to freedomofpress/securedrop that referenced this pull request May 7, 2018
Our unique changes that were added to support suppressing NFS were
recently merged upstream in molecule 2.13:

* ansible/molecule#1235
* ansible/molecule#1233
msheiny added a commit to freedomofpress/securedrop that referenced this pull request May 7, 2018
Our unique changes that were added to support suppressing NFS were
recently merged upstream in molecule 2.13:

* ansible/molecule#1235
* ansible/molecule#1233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants