Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail doc-style action when wrong Vale config is present #470

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

jorgepiloto
Copy link
Member

As per a private discussion, we are forcing the doc-style action to check the Vale configuration layout according to the selected version.

@jorgepiloto jorgepiloto requested a review from a team as a code owner April 23, 2024 13:36
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Apr 23, 2024
doc-style/action.yml Outdated Show resolved Hide resolved
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving suggestions to adapt properly - let's try and get this merged @jorgepiloto

doc-style/action.yml Outdated Show resolved Hide resolved
doc-style/action.yml Outdated Show resolved Hide resolved
doc-style/action.yml Outdated Show resolved Hide resolved
doc-style/action.yml Outdated Show resolved Hide resolved
@RobPasMue RobPasMue enabled auto-merge (squash) April 25, 2024 13:05
@RobPasMue RobPasMue merged commit 5534a0e into main Apr 25, 2024
12 checks passed
@RobPasMue RobPasMue deleted the fix/vale-layout branch April 25, 2024 13:07
RobPasMue added a commit that referenced this pull request Apr 25, 2024
@RobPasMue RobPasMue restored the fix/vale-layout branch April 25, 2024 13:33
@RobPasMue RobPasMue mentioned this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants